fix(ui): constrain cron job entries within list boundary#51201
Merged
BunsDev merged 6 commits intoopenclaw:mainfrom Apr 4, 2026
Merged
fix(ui): constrain cron job entries within list boundary#51201BunsDev merged 6 commits intoopenclaw:mainfrom
BunsDev merged 6 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR applies four CSS-only fixes to prevent cron job rows from overflowing the left list column and overlapping the "New Job" panel. The changes are narrow in scope and well-targeted — no logic, data, or API surface is touched. Key changes:
Two issues worth addressing:
Confidence Score: 4/5
Prompt To Fix All With AIThis is a comment left during a code review.
Path: ui/src/styles/components.css
Line: 1583-1584
Comment:
**`min-width: 0` may be needed for ellipsis to activate on the flex item**
`.cron-job-state-value` lives inside `.cron-job-state-row`, which is a `display: flex` / `justify-content: space-between` container. Flex items default to `min-width: auto`, meaning the item will grow to fit its content rather than shrink. When the item doesn't shrink, `overflow: hidden` has nothing to clip and `text-overflow: ellipsis` never fires.
Adding `min-width: 0` lets the flex item be constrained by the available row width, which is what triggers the ellipsis:
```suggestion
overflow: hidden;
text-overflow: ellipsis;
min-width: 0;
```
This is the same class of fix that `min-width: 0` on `.cron-workspace-main` addresses at the grid level — just applied one level deeper to the inner flex item.
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: ui/src/styles/components.css
Line: 1502-1556
Comment:
**`word-break: break-word` is redundant alongside `overflow-wrap: anywhere`**
`word-break: break-word` is a non-standard legacy value (not in the W3C spec for `word-break`). It was a WebKit alias for `overflow-wrap: break-word`, which is itself a subset of `overflow-wrap: anywhere`. Since `overflow-wrap: anywhere` is already set and is strictly more permissive, `word-break: break-word` adds no additional behavior in compliant browsers.
This applies to both new blocks:
- `.cron-job .list-title` (lines 1502–1503)
- `.cron-job-detail-value` (lines 1555–1556)
Removing it keeps the intent clear without relying on a non-standard value:
```suggestion
overflow-wrap: anywhere;
```
(apply this to both occurrences)
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: "fix(ui): constrain c..." |
Contributor
Author
|
@greptile-apps feedback addressed in 0396820. |
Contributor
Author
Member
|
Thanks for your contribution @Mule-ME |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Fixes #49228. Cron job rows in the Control UI can spill past the left list boundary and overlap the right-side "New Job" panel.
Why
.cron-workspace-maincannot shrink below its content width withoutmin-width: 0. Long title, detail, or state text can therefore push the left column under the right panel.What
min-width: 0to.cron-workspace-main.cron-job .list-titletext.cron-job-detail-valuetext.cron-job-state-valuewith ellipsisTest plan
No new unit test because this is a CSS-only layout fix and the existing cron view test plus Control UI build already cover the touched surface.
pnpm --dir ui test src/ui/views/cron.test.tspnpm --dir ui buildAI-assisted: Codex