fix: mirror bundled extension deps in root package.json (#48189)#48447
fix: mirror bundled extension deps in root package.json (#48189)#48447pragun-ananda wants to merge 4 commits into
Conversation
Extension-only dependencies (google-auth-library, zca-js, nostr-tools, @microsoft/agents-hosting, @matrix-org/matrix-sdk-crypto-nodejs, @vector-im/matrix-bot-sdk, music-metadata, @tloncorp/api, @tloncorp/tlon-skill, @urbit/aura) were not in root package.json, causing "Cannot find package" errors at runtime in Docker and npm global installs. Add all to root dependencies and remove the now-unnecessary rootDependencyMirrorAllowlist entries from each extension. https://claude.ai/code/session_01Lr4en2wqoPyrJfnyV8YxNh
Greptile SummaryThis PR fixes a runtime "Cannot find package" error in Docker and npm global installs by mirroring 10 extension-only dependencies (
Confidence Score: 5/5
Last reviewed commit: 09d3014 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98b864e293
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Closing this as implemented after Codex review. Close. Current What I checked:
So I’m closing this as already implemented rather than keeping a duplicate issue open. Review notes: reviewed against 4013c658537e; fix evidence: commit 48b9452c0795. |
Extension-only dependencies (google-auth-library, zca-js, nostr-tools, @microsoft/agents-hosting, @matrix-org/matrix-sdk-crypto-nodejs, @vector-im/matrix-bot-sdk, music-metadata, @tloncorp/api, @tloncorp/tlon-skill, @urbit/aura) were not in root package.json, causing "Cannot find package" errors at runtime in Docker and npm global installs.
Add all to root dependencies and remove the now-unnecessary rootDependencyMirrorAllowlist entries from each extension.
Summary
Describe the problem and fix in 2–5 bullets:
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
List user-visible changes (including defaults/config).
If none, write
None.None
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
Expected
Actual
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'google-auth-library' imported from /app/dist/api-0XGYdJRK.jsEvidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
Review Conversations
If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.
Compatibility / Migration
No)Yes)No)Failure Recovery (if this breaks)
Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.