Telegram: handle unresolved SecretRefs gracefully in token resolution#47738
Closed
Sathvik-Chowdary-Veerapaneni wants to merge 1 commit into
Closed
Conversation
Contributor
Greptile SummaryThis PR fixes a crash in Changes:
The fix is consistent with the existing pattern used in Confidence Score: 5/5
Last reviewed commit: 16b88d9 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveTelegramTokenthrew on unresolved SecretRef objects (e.g. file-based providers), causingopenclaw doctor --fixto fail even though the gateway runtime resolved the same ref correctly.normalizeResolvedSecretInputString(throws on unresolved refs) withnormalizeSecretInputString+hasConfiguredSecretInput(returns configured-unavailable result), matching the existing pattern inaccount-inspect.ts.Fixes #47686
Test plan
extensions/telegram/src/token.test.ts— 14/14 passed (updated existing throw test, added file SecretRef test)extensions/telegram/src/accounts.test.ts— 23/23 passedsrc/commands/doctor-config-flow.test.ts— 24/24 passedpnpm buildpassespnpm format:checkpassesManual: configure Telegram botToken as a file SecretRef, run
openclaw doctor --fix, verify no throwAI-assisted (Claude)
Fully tested locally