feat: relay ACP completion back to DM sessions#47531
Closed
Groos-dev wants to merge 3 commits into
Closed
Conversation
Author
|
Added commit Groos-dev@83652684:
Net result: the one previously-failing test in this file now passes. All other |
Contributor
|
Closing this as implemented after Codex review. Current What I checked:
So I’m closing this as already implemented rather than keeping a duplicate issue open. Review notes: reviewed against 0e7250f37bf3; fix evidence: release v2026.4.22, commit 00bd2cf7a376. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acp-spawnonly for non-thread, non-parent-stream runs with a deliverable requester originTesting
corepack pnpm exec vitest run src/agents/acp-spawn-completion-relay.test.ts src/agents/acp-spawn-parent-stream.test.tscorepack pnpm exec vitest run src/agents/acp-spawn.test.ts(currently fails onmainwith a pre-existing module mock/load issue insrc/agents/tools/sessions-spawn-tool.ts)Closes #47443