Greptile Summary

This PR fixes a broken test by correcting the message timestamp used in the 'handles append messages by marking them read but skipping auto-reply' test case.

After APPEND_RECENT_GRACE_MS = 60_000 was introduced in monitor.ts (line 416), messages with a timestamp within the last 60 seconds on an "append" upsert are treated as recent and processed normally — rather than skipped. The test was passing nowSeconds() (current time), which fell inside the grace window and caused the message to be processed instead of skipped, breaking the assertion expect(onMessage).not.toHaveBeenCalled().

The fix sets the timestamp to nowSeconds(-120_000) (2 minutes ago), which is clearly outside the 60-second window, restoring the expected skip behavior.

• nowSeconds is defined as (offsetMs = 0) => Math.floor((Date.now() + offsetMs) / 1000), so the argument is a millisecond offset — passing -120_000 correctly produces a timestamp 2 minutes in the past (in seconds), well outside the grace boundary.
• No production behavior is changed; this is a test-only fix.
• The sibling test file (monitor-inbox.blocks-messages-from-unauthorized-senders-not-allowfrom.test.ts) also uses nowSeconds() but only for "notify"-type upserts where the grace window logic does not apply, so no change is needed there.

Confidence Score: 5/5

• Safe to merge — single-line test-only fix that correctly restores intended test behavior with no production code changes.
• The root cause is clearly diagnosed, the fix is minimal and precisely targeted (one line, test file only), the math checks out (2 min > 60 s grace window), and there are no side effects on production logic or other tests.
• No files require special attention.

_{Last reviewed commit: c42339b}

All CI checks are passing ✅. This is a one-line fix that unblocks the channels test suite for all current open PRs — would love a review when you get a chance!

This one-line fix unblocks the channels CI suite for all open PRs — confirmed it is failing identically on our unrelated PRs #37940 and #38232 (as well as #47347, #47305, etc.). Would love to see this merged quickly. 👍

Thanks @who96 for confirming — good to know this unblocks the channels suite for other PRs too. The fix is a one-line timestamp correction so the stale-entry guard doesn't reject legitimately recent appends during tests. Happy to rebase or add anything needed to move this forward.

All CI checks are green ✅ (25 passed, 10 skipped, 0 failed). However, the PR has conflicts with the base branch main that need to be resolved. Could you rebase this PR against the latest main branch? Once rebased, this should be ready for merge since the fix is validated and unblocks the channels test suite for other PRs.

Thank you for the contribution @who96! We appreciate the effort.

This PR's objective has been superseded by commit b2e9221 ("test(whatsapp): fix stale append inbox expectation", Mar 15) merged by maintainer Peter Steinberger. The upstream fix addresses the same issue with equivalent semantics.

Closing as superseded.