fix(sessions): prevent displayName overwrite on outbound sends (#4683)#4697
Closed
saurabhchopda wants to merge 1 commit into
Closed
fix(sessions): prevent displayName overwrite on outbound sends (#4683)#4697saurabhchopda wants to merge 1 commit into
saurabhchopda wants to merge 1 commit into
Conversation
Contributor
|
Closing as duplicate of #4693. If this is incorrect, comment and we can reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sessions): prevent displayName overwrite on outbound sends
Summary
displayNamebeing incorrectly updated to the message recipient when using the message tool to send to a different contactskipDisplayNameoption to session metadata functions to prevent this during outbound sendsFixes #4683
Test plan
skipDisplayNamebehavior inmetadata.test.tsGreptile Overview
Greptile Summary
This PR adds a
skipDisplayNameflag to session metadata derivation so outbound sends don’t overwrite a session’sdisplayNamewith the last recipient. The new option is threaded throughderiveGroupSessionPatch/deriveSessionMetaPatch, exposed viarecordSessionMetaFromInbound, and used byensureOutboundSessionEntryduring outbound message routing. A unit test is added to assertdisplayNameis omitted when the flag is set, and the changelog notes the fix.Confidence Score: 5/5
displayNamederivation behind an explicit flag and only applied in the outbound-session entry path; no schema changes and a targeted unit test covers the new behavior. I did not find any functional regressions in the modified call sites.(2/5) Greptile learns from your feedback when you react with thumbs up/down!