Greptile Summary

This PR fixes the context warning banner to use totalTokens instead of inputTokens when calculating context window usage, which is semantically correct — totalTokens accounts for both input and output tokens and is the accurate measure of how much of the context window has been consumed.

• chat.ts: Single-line fix swapping session?.inputTokens for session?.totalTokens in renderContextNotice. Both fields are optional on GatewaySessionRow, so the existing ?? 0 fallback is still valid.
• chat.browser.test.ts: Fixture updated to include totalTokens, and a well-targeted regression test added to confirm the banner is suppressed when inputTokens is high but totalTokens is low.
• vitest.config.ts: The chat.browser.test.ts file is added to the root config's include list, but it is already picked up by ui/vitest.config.ts's browser project (via src/**/*.browser.test.ts). This causes the test to run twice — once in Playwright/Chromium (the correct environment) and once in the root pool: "forks" Node.js environment that has no DOM or jsdom configured, which is mismatched with a test that relies on getComputedStyle and getBoundingClientRect.

Confidence Score: 3/5

• The core fix is correct, but the vitest.config.ts change duplicates a browser test into the wrong (non-DOM) test environment.
• The one-line change to chat.ts and the accompanying test are both correct and well-motivated. The regression test case is well-written. The score is reduced because adding chat.browser.test.ts to the root vitest.config.ts is incorrect — the file is already run by ui/vitest.config.ts in its proper Playwright/Chromium environment, and running it again under pool: "forks" (Node.js without DOM) is an environment mismatch that can mask real failures.
• vitest.config.ts — the addition of chat.browser.test.ts to the root include list should be removed.

This is a comment left during a code review.
Path: vitest.config.ts
Line: 88

Comment:
**Duplicate test registration causes double test execution**

`ui/vitest.config.ts` already picks up `*.browser.test.ts` files via the `browser` project:

```ts
// ui/vitest.config.ts
defineProject({
  test: {
    name: "browser",
    include: ["src/**/*.browser.test.ts"],  // matches ui/src/ui/views/chat.browser.test.ts
    browser: { enabled: true, provider: playwright(), ... },
  },
}),
```

Adding the same file here means it runs **twice**: once in Playwright/Chromium (the intended environment), and once in this root config's `pool: "forks"` (Node.js) environment — which has no DOM and no `jsdom` environment configured. The root `test/setup.ts` does not establish any DOM globals either.

The `chat.browser.test.ts` test uses real browser APIs (`getComputedStyle`, `getBoundingClientRect`) that require an actual browser or at minimum `jsdom`. Running it under `pool: "forks"` without a DOM environment risks silently degraded assertions or `document is not defined` failures that hide true regressions.

This line should be removed from the root `vitest.config.ts` — the file is already covered by `ui/vitest.config.ts`.

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: 4b259be}

✅ Fixed CI: added environment: "jsdom" to browser test project config in ui/vitest.config.ts. Browser tests now have DOM access and should pass. See commit 12ce092f8.

Closing this as implemented after Codex review.

Current main already implements the requested behavior: the context notice banner uses session.totalTokens instead of session.inputTokens, and there is a regression test for the high-input/low-total case this PR describes.

What I checked:

• Banner logic uses totalTokens on main: ui/src/ui/chat/context-notice.ts computes context usage from session?.totalTokens and not inputTokens, with a freshness guard before rendering. (ui/src/ui/chat/context-notice.ts:56, f85806b6d786)
• Regression test matches the PR's bug report: ui/src/ui/chat/context-notice.test.ts asserts the banner stays hidden when inputTokens is high but totalTokens is low, and also verifies the rendered detail shows 190k / 200k rather than the larger inputTokens value. (ui/src/ui/chat/context-notice.test.ts:32, f85806b6d786)
• Main chat view uses the shared fixed helper: ui/src/ui/views/chat.ts renders the banner through renderContextNotice(activeSession, ...), so the fixed logic is what current UI paths use. (ui/src/ui/views/chat.ts:1192, 56fe2aab9c87)
• Blame points the current implementation to a mainline commit: git blame on the relevant lines attributes the totalTokens logic in ui/src/ui/chat/context-notice.ts to commit f85806b6d78698fb6b6060d09e16cb09ae40131b, showing the behavior is already present on current main. (ui/src/ui/chat/context-notice.ts:56, f85806b6d786)

So I’m closing this as already implemented rather than keeping a duplicate issue open.

Review notes: reviewed against 56fe2aab9c87; fix evidence: commit f85806b6d786.