fix(feishu): decode RFC 5987 filename for file downloads by guang384 · Pull Request #43983 · openclaw/openclaw

guang384 · 2026-03-12T11:24:24Z

Summary

Problem

When sending files with non-ASCII filenames (Chinese, Japanese, emoji) in Lark/Feishu, the filename appears URL-encoded (e.g., %E6%B5%8B%E8%AF%95.txt instead of 测试.txt).

Root Cause

The backend receives the Content-Disposition header with RFC 5987 encoded filename (filename*=UTF-8...) but fails to decode it using decodeURIComponent before storing/displaying.

Changes

Add decodeRfc5987Filename() helper function to decode percent-encoded filenames
Apply to file message display (line 437)
Apply to file download metadata (line 539)

Test

Prepare a file with non-ASCII filename (e.g., 测试.pdf)
Send the file via Lark/Feishu client
Verify the filename displays correctly as 测试.pdf instead of URL-encoded string

Fixes openclaw#43840 - Add decodeRfc5987Filename() to decode percent-encoded filenames - Apply to file message display (line 437) - Apply to file download metadata (line 539)

greptile-apps · 2026-03-12T11:26:19Z

Greptile Summary

This PR adds a decodeFeishuFilename() helper to extensions/feishu/src/bot.ts and applies it to all parsed.file_name usages, fixing the display of non-ASCII filenames (Chinese, Japanese, emoji) sent through Lark/Feishu. The function handles both plain percent-encoded filenames and the RFC 5987 filename*=charset'lang'encoded format.

All issues raised in previous review rounds have been addressed in this revision:

decodeURIComponent calls are guarded with try/catch in both the RFC 5987 and plain-filename branches.
The RFC 5987 charset matching is case-insensitive (/i flag), so utf-8, UTF-8, etc. all match.
Non-empty language tags (e.g. UTF-8'zh-CN'…) are correctly stripped by the [^']* capture in the regex.
The stale duplicate JSDoc has been removed; the current doc comment accurately describes what the function does.
The test file is a single clean describe block with no duplicate suites, no stray });, and no top-level it() calls.
A new test case ("decodes RFC 5987 with language tag") explicitly covers the language-tag path.

The CHANGELOG entry wording ("instead of using RFC 5987 format") is slightly imprecise — the implementation supports RFC 5987 in addition to plain URL-encoded names — but this is a cosmetic concern and does not affect correctness.

Confidence Score: 5/5

This PR is safe to merge; all previously flagged issues have been resolved and no new issues were found.
The helper is well-scoped with proper error handling, case-insensitive matching, and RFC 5987 language-tag support. The test suite covers the main paths including the RFC 5987-with-language-tag case. No regressions are expected since the function only changes behaviour for filenames that are either RFC 5987-prefixed or decode to a string containing non-ASCII characters.
No files require special attention.

_{Last reviewed commit: 734171e}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88320de187

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ademczuk

Thanks for tackling the Feishu non-ASCII filename display issue. The problem is real and affects users with CJK filenames.

A few things to flag:

1. Stronger competing PR exists

#43916 by @ccsang addresses the same bug with a more comprehensive approach: exported/testable decoder function, 8 tests, CHANGELOG entry, and fixes across both bot.ts and media.ts (upload side as well as display). It also covers the UI tool cards. Given that #43916 is further along, it might be worth coordinating with that PR rather than duplicating effort.

2. The filename*=UTF-8'' prefix check is likely dead code

Feishu's JSON payloads send file_name as plain encodeURIComponent output (e.g. %E6%B5%8B%E8%AF%95.pdf), not the RFC 5987 format (filename*=UTF-8''%E6%B5%8B%E8%AF%95.pdf). RFC 5987 is an HTTP header encoding format, not a JSON payload format. The startsWith("filename*=UTF-8''") branch will never trigger for real Feishu messages, making that path dead code. The function should likely just call decodeURIComponent directly.

3. Missing try/catch around decodeURIComponent

decodeURIComponent throws URIError on malformed percent-encoded strings (e.g. truncated %E6%). In parseMediaKeys, the outer try/catch returns {} on any error, which would silently drop the fileKey and break file downloads for an otherwise valid file. A try/catch inside the decoder with a fallback to the raw string would be safer.

4. Function is private

decodeRfc5987Filename is scoped as a module-private function in bot.ts, which makes it impossible to unit test directly. Exporting it (as #43916 does) would allow focused tests.

5. No tests or CHANGELOG

Both are expected for user-facing bug fixes per CONTRIBUTING.md.

The core idea is sound. If #43916 stalls, addressing the points above would make this a solid alternative.

- Remove dead RFC 5987 code path (not used by Feishu JSON) - Add try/catch for decodeURIComponent to prevent crashes - Export function for unit testing - Add CHANGELOG entry

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b493b2e5c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 821a262e2e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T12:37:11Z

@codex review

chatgpt-codex-connector · 2026-03-16T12:41:52Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T12:43:00Z

@greptileai review

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 415fa98b90

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d006d11f7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T13:08:25Z

@codex review

guang384 · 2026-03-16T19:19:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c49d3624b9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T19:35:31Z

@codex review

chatgpt-codex-connector · 2026-03-16T19:41:16Z

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T19:43:02Z

@greptileai review

guang384 · 2026-03-16T19:51:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7231b0d531

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T20:06:55Z

@codex review

chatgpt-codex-connector · 2026-03-16T20:11:28Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T20:13:03Z

@greptileai review

guang384 · 2026-03-16T20:23:00Z

@codex review

chatgpt-codex-connector · 2026-03-16T20:28:10Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T20:28:56Z

@greptileai review

guang384 · 2026-03-16T20:35:13Z

@codex review

chatgpt-codex-connector · 2026-03-16T20:39:56Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

guang384 · 2026-03-16T20:40:49Z

@greptileai review

guang384 · 2026-03-16T20:53:49Z

Thanks @ademczuk for the review!

I've addressed all the Greptile feedback and the PR now has a 5/5 confidence score. The fix:

Decodes RFC 5987 filenames (including language tag)
Decodes plain percent-encoded non-ASCII filenames
Applies decoding to all media types consistently (image, file, audio, video, sticker)

I saw #43916 by @ccsang - that's a comprehensive solution too! Would be great to get either this or #43916 merged to fix the non-ASCII filename issue. Thanks!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39e8811a3d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d6839ccda

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

steipete · 2026-04-25T07:22:18Z

Closing this as implemented after Codex review.

Current main already fixes the reported Feishu filename symptom through the shipped upload-path change in v2026.3.12, and it also already decodes RFC 5987 download header filenames. This PR's extra JSON file_name decoding is therefore redundant against the current codebase.

What I checked:

Changelog shipped fix: v2026.3.12 changelog already records the Feishu filename fix: preserve literal UTF-8 filenames in im.file.create so non-ASCII names no longer appear percent-encoded in chat (#34262). (CHANGELOG.md:2670, 50e36983bb2d)
Release section: The surrounding changelog section shows that entry shipped in release v2026.3.12. (CHANGELOG.md:2586, 50e36983bb2d)
Current upload implementation: Current Feishu upload code preserves UTF-8 filenames instead of percent-encoding them, matching the shipped fix. (extensions/feishu/src/media.ts:359, 50e36983bb2d)
Current regression test: Current tests verify uploads send a literal non-ASCII filename (测试文档.pdf) in file_name. (extensions/feishu/src/media.test.ts:463, 50e36983bb2d)
Current download-header decoding: Current download metadata extraction already decodes filename*=UTF-8''... from Content-Disposition, covering the RFC 5987 header case on downloads. (extensions/feishu/src/media.ts:127, 50e36983bb2d)

So I’m closing this as already implemented rather than keeping a duplicate issue open.

Review notes: reviewed against 50e36983bb2d; fix evidence: release v2026.3.12.

fix(feishu): decode RFC 5987 filename for file downloads

88320de

Fixes openclaw#43840 - Add decodeRfc5987Filename() to decode percent-encoded filenames - Apply to file message display (line 437) - Apply to file download metadata (line 539)

openclaw-barnacle Bot added channel: feishu Channel integration: feishu size: XS labels Mar 12, 2026

greptile-apps Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts Outdated

Comment thread extensions/feishu/src/bot.ts Outdated

chatgpt-codex-connector Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts Outdated

ademczuk reviewed Mar 12, 2026

View reviewed changes

fix(feishu): decode URL-encoded filenames with try/catch

2b493b2

- Remove dead RFC 5987 code path (not used by Feishu JSON) - Add try/catch for decodeURIComponent to prevent crashes - Export function for unit testing - Add CHANGELOG entry

openclaw-barnacle Bot added size: S and removed size: XS labels Mar 16, 2026

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts Outdated

fix(feishu): preserve literal percent signs in filenames

821a262

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts Outdated

fix(feishu): only decode non-ASCII filenames to preserve literal %XX

83c3333

greptile-apps Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts Outdated

Comment thread extensions/feishu/src/bot.filename-decode.test.ts Outdated

guang384 and others added 2 commits March 16, 2026 20:47

Update extensions/feishu/src/bot.filename-decode.test.ts

6ba43d4

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chore: update CHANGELOG from main

04560ca

openclaw-barnacle Bot added size: M and removed size: S labels Mar 16, 2026

chore: add fix to latest version in CHANGELOG

415fa98

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts

Merge branch 'main' into fix/issue-43840

3d006d1

openclaw-barnacle Bot added size: S and removed size: M labels Mar 16, 2026

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts

fix(feishu): strip RFC5987 prefix before decoding

b8f5b1d

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts Outdated

fix(feishu): simplify - only decode if result has non-ASCII

277c28a

fix(feishu): apply decode to all file types

7231b0d

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts

fix(feishu): RFC 5987 always decode, plain only if non-ASCII

448e62f

test(feishu): add test for plain percent-encoded filenames

cd1c723

fix(feishu): apply decode to image case too

734171e

Merge branch 'main' into fix/issue-43840

39e8811

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

guang384 and others added 2 commits March 17, 2026 05:07

chore: update CHANGELOG

5ead9fe

Merge branch 'main' into fix/issue-43840

1d6839c

chatgpt-codex-connector Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread extensions/feishu/src/bot.ts

steipete closed this Apr 25, 2026

jbetala7 mentioned this pull request May 19, 2026

Remote media URL fallback filenames keep percent escapes #84050

Closed

Uh oh!

Conversation

guang384 commented Mar 12, 2026

Summary

Problem

Root Cause

Changes

Test

Uh oh!

greptile-apps Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ademczuk left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 16, 2026

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 16, 2026

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 16, 2026

Uh oh!

guang384 commented Mar 16, 2026

Uh oh!

greptile-apps Bot commented Mar 12, 2026 •

edited

Loading