fix: restore export-html template placeholders and prevent reformatting#43634
fix: restore export-html template placeholders and prevent reformatting#43634iteemoo6 wants to merge 1 commit into
Conversation
- Fix template.html placeholders that were broken by formatter
- Add template.html to .gitattributes to prevent future reformatting
- The {{MARKED_JS}}, {{HIGHLIGHT_JS}}, {{JS}} placeholders were being split into multiple lines
- Also keep {{CSS}} and {{SESSION_DATA}} in their original format
Closes openclaw#43616, openclaw#43620
Greptile SummaryThis PR fixes a regression where a code formatter corrupted the five template placeholders ( Key changes:
No functional issues found. The placeholder strings exactly match what Confidence Score: 5/5
Last reviewed commit: 7428668 |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing this as duplicate or superseded after Codex automated review. Close this PR as superseded by open PR #41861 and open issue #41862. The export-session HTML bug is real and still present on current main, but this PR is a narrower duplicate fix: it restores template placeholders and adds a .gitattributes marker, while #41861 is the better canonical fix because it also changes JS/vendor asset injection to function replacers to avoid String.replace Best possible solution: Close this PR as superseded and keep the remaining work focused on #41861/#41862. The best fix should restore formatter-safe template placeholders, use function replacers for injected JS/vendor assets, add a regression test that reads the real template.html path, and verify the build-copy path ships corrected export assets. What I checked:
So I’m closing this here and keeping the remaining discussion on the canonical linked item. Codex Review notes: model gpt-5.5, reasoning high; reviewed against 91e835ebe0ab. |
This PR fixes the export-html template that was broken by a formatter.
What was broken:
What this PR does:
Closes #43616, #43620