Skip to content

test(config): cover requiresOpenAiAnthropicToolPayload in compat schema fixture#43438

Merged
obviyus merged 1 commit intoopenclaw:mainfrom
xingsy97:wt/test-compat-key
Mar 13, 2026
Merged

test(config): cover requiresOpenAiAnthropicToolPayload in compat schema fixture#43438
obviyus merged 1 commit intoopenclaw:mainfrom
xingsy97:wt/test-compat-key

Conversation

@xingsy97
Copy link
Copy Markdown
Contributor

Adds the missing requiresOpenAiAnthropicToolPayload field to the model-compat schema acceptance test in config-misc.test.ts, guarding against regressions like #43339 where onboarding fails with "Unrecognized key".

1 line, test-only. Closes #43339

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 11, 2026

Greptile Summary

This PR adds the missing requiresOpenAiAnthropicToolPayload field to the "accepts full openai-completions compat fields" test fixture in config-misc.test.ts, ensuring the acceptance test covers all fields defined in the .strict() compat Zod schema. The field was already present in the schema (zod-schema.core.ts) but absent from the test, meaning regressions where the field is accidentally dropped from the schema (as happened in #43339) would go undetected.

  • Adds requiresOpenAiAnthropicToolPayload: true to the test fixture — a one-line, test-only change with no production code impact.
  • The field is correctly typed as boolean in both the schema and the fixture.
  • No other compat fields appear to be missing from the fixture.

Confidence Score: 5/5

  • This PR is safe to merge — it is a one-line test-only addition with no production code changes.
  • The change is minimal and correct: the added field exists in the Zod schema, its value (true) is a valid boolean, and the surrounding test logic is unchanged. There is no risk of regression.
  • No files require special attention.

Last reviewed commit: dd3667c

@xingsy97
Copy link
Copy Markdown
Contributor Author

xingsy97 commented Mar 12, 2026

Hi @obviyus, his is ready for review. CI is green, greptile scored 5/5. Adds the missing requiresOpenAiAnthropicToolPayload field to the model-compat schema test fixture (#43339). 1 line, test-only. Happy to address any feedback.

@xingsy97
Copy link
Copy Markdown
Contributor Author

xingsy97 commented Mar 13, 2026

Hi @altaywtf ,this is a 1-line test-only change (greptile 5/5). Adds the missing requiresOpenAiAnthropicToolPayload field to the compat schema acceptance fixture. Closes #43339.

…ma fixture

Adds the missing requiresOpenAiAnthropicToolPayload field to the
model-compat schema acceptance test, guarding against regressions
like openclaw#43339 where onboarding fails with "Unrecognized key".

Closes openclaw#43339
@obviyus obviyus force-pushed the wt/test-compat-key branch from dd3667c to 1994051 Compare March 13, 2026 09:31
@obviyus obviyus merged commit b28a225 into openclaw:main Mar 13, 2026
27 checks passed
@obviyus
Copy link
Copy Markdown
Contributor

obviyus commented Mar 13, 2026

Landed on main.

Thanks @xingsy97.

@xingsy97 xingsy97 deleted the wt/test-compat-key branch March 13, 2026 09:35
@obviyus obviyus self-assigned this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: models.providers.kimi-coding.models.0.compat: Unrecognized key: "requiresOpenAiAnthropicToolPayload"

2 participants