feat(android): add inline Adaptive Card rendering in chat#42304
feat(android): add inline Adaptive Card rendering in chat#42304VikrantSingh01 wants to merge 3 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR introduces native Adaptive Card rendering in the Android chat UI by adding However, there are a few issues that should be addressed before merging:
Confidence Score: 2/5
Last reviewed commit: 0a0c9af |
| fun parseAdaptiveCardMarkers(text: String): ParsedAdaptiveCard? { | ||
| val match = cardMarkerRegex.find(text) ?: return null | ||
| val jsonStr = match.groupValues[1].trim() | ||
| val fallback = text.substring(0, match.range.first).trim() |
There was a problem hiding this comment.
Text after card marker is silently dropped
fallbackText is set to only the substring before the opening marker. Any text appearing after <!--/adaptive-card--> is never captured and is silently discarded.
For example, if the AI message is:
Here is your summary:
<!--adaptive-card-->...<!--/adaptive-card-->
Please review the above card carefully.
The trailing sentence "Please review the above card carefully." would never be rendered.
Consider capturing the suffix text as well:
val prefix = text.substring(0, match.range.first).trim()
val suffix = text.substring(match.range.last + 1).trim()
val fallback = listOf(prefix, suffix).filter { it.isNotBlank() }.joinToString("\n\n")Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/chat/AdaptiveCardParser.kt
Line: 22
Comment:
**Text after card marker is silently dropped**
`fallbackText` is set to only the substring *before* the opening marker. Any text appearing after `<!--/adaptive-card-->` is never captured and is silently discarded.
For example, if the AI message is:
```
Here is your summary:
<!--adaptive-card-->...<!--/adaptive-card-->
Please review the above card carefully.
```
The trailing sentence "Please review the above card carefully." would never be rendered.
Consider capturing the suffix text as well:
```kotlin
val prefix = text.substring(0, match.range.first).trim()
val suffix = text.substring(match.range.last + 1).trim()
val fallback = listOf(prefix, suffix).filter { it.isNotBlank() }.joinToString("\n\n")
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Fixed in 9fb29e3. Parser now captures both prefix and suffix text around markers, stripping any <!--adaptive-card-data--> blocks from the suffix.
| private fun RenderContainer(element: Map<String, Any>) { | ||
| val items = element.typedList("items") | ||
| Column(verticalArrangement = Arrangement.spacedBy(4.dp)) { | ||
| for (item in items) { | ||
| RenderElement(item) | ||
| } | ||
| } |
There was a problem hiding this comment.
Unbounded recursion can cause StackOverflowError
RenderContainer calls RenderElement for each item, RenderElement can call RenderContainer (or RenderColumnSet → RenderElement → …) again, with no depth limit. A deeply nested card — or a maliciously crafted one — can exhaust the call stack and crash the app.
Consider tracking a depth counter and bailing out once it exceeds a reasonable bound (e.g. 10):
@Composable
private fun RenderElement(element: Map<String, Any>, depth: Int = 0) {
if (depth > 10) {
Log.w(TAG, "Max nesting depth exceeded, skipping element")
return
}
// pass depth + 1 to RenderContainer / RenderColumnSet
...
}Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/chat/AdaptiveCardComposable.kt
Line: 173-179
Comment:
**Unbounded recursion can cause `StackOverflowError`**
`RenderContainer` calls `RenderElement` for each item, `RenderElement` can call `RenderContainer` (or `RenderColumnSet` → `RenderElement` → …) again, with no depth limit. A deeply nested card — or a maliciously crafted one — can exhaust the call stack and crash the app.
Consider tracking a depth counter and bailing out once it exceeds a reasonable bound (e.g. 10):
```kotlin
@Composable
private fun RenderElement(element: Map<String, Any>, depth: Int = 0) {
if (depth > 10) {
Log.w(TAG, "Max nesting depth exceeded, skipping element")
return
}
// pass depth + 1 to RenderContainer / RenderColumnSet
...
}
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Fixed in 9fb29e3. Added depth: Int = 0 parameter to RenderElement. Returns early when depth > 10. All recursive call sites pass depth + 1.
| @@ -28,6 +28,8 @@ import androidx.compose.ui.unit.sp | |||
| import ai.openclaw.app.chat.ChatMessage | |||
| import ai.openclaw.app.chat.ChatMessageContent | |||
| import ai.openclaw.app.chat.ChatPendingToolCall | |||
| import ai.openclaw.app.chat.parseAdaptiveCardMarkers | |||
| import ai.openclaw.app.chat.stripCardMarkers | |||
There was a problem hiding this comment.
Unused import
stripCardMarkers is imported but never called anywhere in this file. It can be safely removed.
| import ai.openclaw.app.chat.stripCardMarkers | |
| import ai.openclaw.app.chat.parseAdaptiveCardMarkers |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/chat/ChatMessageViews.kt
Line: 32
Comment:
**Unused import**
`stripCardMarkers` is imported but never called anywhere in this file. It can be safely removed.
```suggestion
import ai.openclaw.app.chat.parseAdaptiveCardMarkers
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Fixed in 9fb29e3. Removed unused stripCardMarkers import.
| val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() | ||
| ?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f |
There was a problem hiding this comment.
Dead else branch — both arms of the ternary return 1f
The fallback expression always evaluates to 1f regardless of which branch is taken, making the if/else pointless:
?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f
// ^^^^ same valueThis also means that an Adaptive Card column using an integer weight string (e.g., "width": "2") would never apply a proportional weight — toFloatOrNull() on "2" returns 2f correctly, but any string that fails to parse (e.g. "half") silently falls back to 1f without distinction. Simplify to:
| val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() | |
| ?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f | |
| val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() ?: 1f |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/chat/AdaptiveCardComposable.kt
Line: 157-158
Comment:
**Dead `else` branch — both arms of the ternary return `1f`**
The fallback expression always evaluates to `1f` regardless of which branch is taken, making the `if`/`else` pointless:
```kotlin
?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f
// ^^^^ same value
```
This also means that an Adaptive Card column using an integer weight string (e.g., `"width": "2"`) would never apply a proportional weight — `toFloatOrNull()` on `"2"` returns `2f` correctly, but any string that fails to parse (e.g. `"half"`) silently falls back to `1f` without distinction. Simplify to:
```suggestion
val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() ?: 1f
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Fixed in 9fb29e3. Simplified to val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() ?: 1f.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a0c9af68f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| fun parseAdaptiveCardMarkers(text: String): ParsedAdaptiveCard? { | ||
| val match = cardMarkerRegex.find(text) ?: return null | ||
| val jsonStr = match.groupValues[1].trim() | ||
| val fallback = text.substring(0, match.range.first).trim() |
There was a problem hiding this comment.
Preserve text after adaptive-card marker blocks
The parser only stores text.substring(0, match.range.first) as fallback text, so any user-visible text that appears after <!--/adaptive-card--> is dropped once a card is detected. In ChatMessageBody, this fallback is the only non-card text rendered for parsed messages, which means messages containing intro + card + trailing explanation (or multiple card blocks) lose content in the UI.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 9fb29e3 — same fix as the Greptile comment above (captures both prefix and suffix text).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fb29e38b0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Parse <!--adaptive-card--> markers in message text and render the card JSON natively using Jetpack Compose. Supports TextBlock, FactSet, ColumnSet, Container, Image (placeholder), Action.Submit, and Action.OpenUrl elements. No new Gradle dependencies required. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9fb29e3 to
33b9164
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33b9164f3c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() | ||
| ?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f | ||
|
|
||
| Column( | ||
| modifier = Modifier.weight(weight), |
There was a problem hiding this comment.
Validate parsed column widths before applying weight
RenderColumnSet converts column["width"] to a float and feeds it directly into Modifier.weight(weight) without checking that it is finite and greater than zero. If a card contains width values like "0", "-1", or "NaN" (easy to hit with malformed or model-generated payloads), Compose throws when applying the modifier and the message render path crashes instead of failing gracefully.
Useful? React with 👍 / 👎.
| private val cardMarkerRegex = | ||
| Regex("<!--adaptive-card-->(.*?)<!--/adaptive-card-->", RegexOption.DOT_MATCHES_ALL) |
There was a problem hiding this comment.
Parse template-data markers when extracting adaptive cards
The parser only matches <!--adaptive-card-->...<!--/adaptive-card--> and reads templateData only from inside that JSON object, so it ignores the separate <!--adaptive-card-data-->...<!--/adaptive-card-data--> payload format. When messages carry template data in that marker, Android loses the binding context and card expressions render with unresolved placeholders or missing dynamic values.
Useful? React with 👍 / 👎.
Add Table, RichTextBlock, CodeBlock, ActionSet, ImageSet, Rating, ProgressBar renderers. Fix template data extraction from markers. Fix fallback text to strip all markers. Add Action.Execute support. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84419a6817
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| else -> 5 | ||
| } | ||
|
|
||
| val fullStars = value.toInt().coerceIn(0, max) |
There was a problem hiding this comment.
Guard negative rating max before coerceIn
RenderRating derives max directly from card data and then calls value.toInt().coerceIn(0, max). If a malformed or model-generated card sends a negative max (for example -1), coerceIn throws IllegalArgumentException, which crashes chat rendering for that message instead of degrading gracefully. Clamp max to a non-negative minimum (or skip rendering) before this call.
Useful? React with 👍 / 👎.
| val widthStr = column["width"] as? String | ||
| val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() |
There was a problem hiding this comment.
Handle numeric column widths in ColumnSet
RenderColumnSet only reads column["width"] as a String, but valid card payloads often provide weighted widths as JSON numbers (for example "width": 2), which org.json parses as Number. In that case this code falls back to 1f, so intended layouts like 2:1 are rendered as equal-width columns. Parse both numeric and string width values before defaulting.
Useful? React with 👍 / 👎.
| * Returns null when no card markers are present. | ||
| */ | ||
| fun parseAdaptiveCardMarkers(text: String): ParsedAdaptiveCard? { | ||
| val match = cardMarkerRegex.find(text) ?: return null |
There was a problem hiding this comment.
Avoid dropping additional adaptive-card blocks
parseAdaptiveCardMarkers uses find to capture only the first card block, but fallback text is produced by removing all card markers from the message. When a response contains multiple <!--adaptive-card-->...<!--/adaptive-card--> sections, only the first card is renderable and later cards are silently lost. This should either parse/render all matches or preserve unmatched card blocks in fallback text.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51f5f23c6d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (parsed.fallbackText.isNotBlank()) { | ||
| ChatMarkdown(text = parsed.fallbackText, textColor = textColor) | ||
| } | ||
| AdaptiveCardView(card = parsed.card) |
There was a problem hiding this comment.
Apply parsed template data before rendering cards
The parser now extracts templateData from <!--adaptive-card-data-->...<!--/adaptive-card-data-->, but ChatMessageBody drops it and renders only parsed.card. As a result, cards that use templated fields (for example ${userName} in TextBlock.text) render unresolved placeholders on Android even when valid template data is present in the message payload.
Useful? React with 👍 / 👎.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
BradGroux
left a comment
There was a problem hiding this comment.
Review: Android Adaptive Card Renderer (Jetpack Compose)
666 lines adding an Android renderer with AdaptiveCardParser.kt (marker parsing + org.json Map conversion) and AdaptiveCardComposable.kt (Jetpack Compose renderer for AC v1.6 elements). Integration into ChatMessageViews.kt renders fallback markdown alongside the card UI. The Compose implementation is solid and covers a wide range of element types.
Blocker
1. JSONObject.NULL is coerced to empty string, silently breaking null semantics
private fun unwrapJsonValue(value: Any): Any {
return when (value) {
...
JSONObject.NULL -> ""
else -> value
}
}This converts all JSON null values into empty strings "". Downstream rendering logic that checks for null/absent values (optional fields, conditional visibility, boolean checks) will behave incorrectly because "" is truthy in most comparisons. For example, an optional subtitle field that should hide a TextBlock when null will instead render an empty text block. The fix is to map JSONObject.NULL to Kotlin null and handle nullability properly in the renderer.
Suggestions
2. templateData is parsed but never consumed
data class ParsedAdaptiveCard(
...,
val templateData: Map<String, Any>? = null
)
// templateData is extracted from markers and stored, but no renderer path reads itThe parser extracts template data from <!--adaptive-card-data--> markers and stores it in the parsed result, but the renderer never applies template binding. Either implement the binding step (replacing ${expression} placeholders using the data) or remove the field and extraction to avoid dead code confusion.
3. Action.OpenUrl opens URIs without scheme validation
uriHandler.openUri(it)There is no allowlist on URL schemes before calling openUri. A card with javascript:, file:, content:, or intent: scheme URLs could trigger unintended behavior on Android. Gate this behind a scheme check (allow https and http only, or at minimum block known dangerous schemes).
4. Action row layout does not handle overflow
Row(...) {
for (action in actions) {
RenderAction(action, modifier = Modifier.weight(1f))
}
}With many actions, each button gets an increasingly small weight(1f) slice. On narrow devices, buttons will clip or become unreadable. Consider wrapping with FlowRow (which appears to be imported but unused) or capping visible actions with an overflow menu.
Nits
- There is an unused
FlowRowimport that may have been intended for the action overflow case above. - The
renderImagecomposable usespainterResource(R.drawable.ic_placeholder)as a placeholder, but actual image loading (Coil/Glide) is not wired up. This is likely a known TODO but worth noting.
Summary
Solid Compose implementation with good element coverage. The NULL coercion blocker will cause subtle rendering bugs with any card that uses optional fields (which is most real-world cards). Fix that, validate URL schemes on OpenUrl, and clean up the dead templateData path.
|
This pull request has been automatically marked as stale due to inactivity. |
|
Codex review: found issues before merge. Summary Reproducibility: yes. for the PR review blockers: source inspection of the PR head shows enabled log-only action buttons, direct URI opening, reordered fallback rendering, dropped templateData, and malformed-card crash paths. I did not run Android UI tests in this read-only review. Next step before merge Security Review findings
Review detailsBest possible solution: Land a revised Android renderer only after maintainer scope approval, with preserved message order, template-data handling or removal, safe action semantics, URL scheme allowlisting, malformed-card guards, focused Android coverage, and a user-facing changelog entry. Do we have a high-confidence way to reproduce the issue? Yes for the PR review blockers: source inspection of the PR head shows enabled log-only action buttons, direct URI opening, reordered fallback rendering, dropped templateData, and malformed-card crash paths. I did not run Android UI tests in this read-only review. Is this the best way to solve the issue? No. The direction may be useful, especially with the linked external plugin, but this diff is not the narrowest maintainable solution until action semantics, URL policy, fallback ordering, template handling, and payload hardening are resolved. Full review comments:
Overall correctness: patch is incorrect Security concerns:
Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against a7c5a0425988. |
Summary
Adds native Adaptive Card rendering to the Android app. When a chat message contains
<!--adaptive-card-->markers, the card is parsed and rendered inline in the chat bubble using Jetpack Compose.New files
AdaptiveCardParser.kt— marker extraction + JSON parsingAdaptiveCardComposable.kt— Compose renderer for AC v1.6 elementsModified files
ChatMessageViews.kt— card detection inChatMessageBodybefore markdown renderElement support
TextBlock, FactSet, ColumnSet, Container, Image, Action.Submit, Action.OpenUrl
Performance target
<50ms first render, <2MB memory per card.
Ecosystem Context
This PR is part of the Adaptive Cards feature set powered by:
adaptive_cardtool, MCP bridge, channel-aware prompt guidance, fallback text generation, action routingThe plugin emits
<!--adaptive-card-->markers in tool result text. This PR adds the Android client-side parser and Jetpack Compose renderer that consumes those markers.Related PRs