Greptile Summary

This PR fixes a real bug on macOS (APFS) and Windows (NTFS) where case-insensitive filesystem handling was broken. The issue: normalizeConfiguredSafeBins() lowercased safe-bin paths, but normalizeTrustedDir() preserved the original case, causing Set.has() lookups to fail and produce spurious "outside trusted safe-bin dirs" doctor warnings.

The fix is minimal and correct:

• Adds a CASE_INSENSITIVE_FS constant to identify darwin/win32 platforms
• Applies lowercasing consistently in both normalizeTrustedDir() (write-time) and isTrustedSafeBinPath() (read-time)
• Matches the established pattern already used in exec-command-resolution.ts
• Includes two new it.runIf tests to verify case-insensitive matching on darwin/win32
• All existing tests updated correctly for the lowercased Set entries

The fix is logically sound and well-tested. No logic bugs or functional issues identified.

Confidence Score: 5/5

• Safe to merge. The fix is logically correct, well-tested, and follows established patterns in the codebase.
• The root cause of the case-insensitive filesystem bug is clearly identified and correctly fixed. Both sides of the Set comparison are now consistently lowercased on darwin/win32. All test cases pass and are properly updated. The implementation matches the existing pattern in exec-command-resolution.ts. No functional issues, logic errors, or regressions identified.
• No files require special attention.

_{Last reviewed commit: 7d02888}

Addressed both review comments:

P1 (Windows paths): Fixed in e8b0655 — tests now use path.join(path.sep, ...) and path.resolve(...).toLowerCase() instead of hardcoded POSIX paths, so they work with Windows backslash separators.

P2 (Case-sensitive APFS): Valid point in theory — APFS can be configured as case-sensitive. In practice this is extremely rare (macOS default is case-insensitive, and Disk Utility warns against it for compatibility). The existing normalizeMatchTarget() in exec-command-resolution.ts already lowercases unconditionally on all non-win32 platforms, so this PR is consistent with the codebase pattern. A runtime fs.realpathSync probe would be more correct but adds I/O on every trust check — happy to add it if maintainers prefer that approach.

P2→P1 (Case-sensitive APFS): Addressed in 8ea4f62. Replaced the static process.platform heuristic with a runtime inode-based filesystem probe:

function detectCaseInsensitiveFs(): boolean {
  const tmpDir = os.tmpdir();
  const original = fs.statSync(tmpDir);
  const flipped = fs.statSync(tmpDir.toUpperCase());
  return original.ino === flipped.ino && original.dev === flipped.dev;
}

This correctly handles case-sensitive APFS volumes on macOS — if the FS is case-sensitive, no lowercasing occurs. Falls back to the platform heuristic if the probe fails. Tests updated to use the same probe for expectations.

Re: per-path case sensitivity detection — acknowledged. A per-path probe (stat the directory itself with flipped case) would handle cross-volume mounts with mixed case sensitivity. However this adds a statSync pair per trusted dir entry on every build, and the scenario (tmpdir on case-insensitive APFS, safeBins on a case-sensitive secondary mount) is extremely niche.

Happy to add per-path probing if maintainers want it, but I'd suggest landing the tmpdir probe first as a significant improvement over the status quo (no case handling at all) and iterating if the edge case comes up in practice.

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Codex review: needs maintainer review before merge.

Summary
The PR adds path-local case-sensitivity probing for safe-bin trusted-dir comparisons, preserves original paths for writable-dir diagnostics, adds regression tests, and updates the changelog.

Reproducibility: yes. by source inspection: current main lowercases configured safeBins, preserves trusted-dir case, and then exact-matches the resolved executable directory. I did not run a live macOS or Windows doctor reproduction in this read-only review.

Real behavior proof
Sufficient (terminal): Sufficient: the PR body includes copied live macOS terminal output showing a real swapped-case temp dir statting to the same object and trusted: true after the patch.

Next step before merge
Manual CI handling remains because the exact PR head has a failing core check with no actionable annotation; this review found no narrow repairable code defect.

Security
Cleared: Cleared: the diff changes local path normalization, tests, and changelog only; it adds no dependencies, workflows, secrets handling, or new external code execution sources.

Re-review progress:

• State: Complete
• Detail: The targeted re-review finished, the durable review comment was updated, and the synced verdict was routed.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/25620627505
• Updated: 2026-05-10T05:26:05.850Z

Prepared maintainer update at 61ce0816950ddfac52b384c4484938d2d15ab4d7 after rebasing onto current main.

Changes made:

• Replaced the global temp-dir case probe with path-local case folding for the trusted-dir comparison key.
• Kept writable trusted-dir diagnostics reporting the configured resolved path instead of the folded comparison key.
• Added regression coverage for case-insensitive matching and case-sensitive sibling separation.
• Added the required changelog entry.

Verification:

• pnpm test src/infra/exec-safe-bin-trust.test.ts src/infra/exec-safe-bin-runtime-policy.test.ts src/commands/doctor-config-flow.safe-bins.test.ts passed before the final base refresh: 33 tests.
• pnpm test:changed passed before the final base refresh: 346 files / 3454 tests.
• pnpm exec oxfmt --check CHANGELOG.md src/infra/exec-safe-bin-trust.ts src/infra/exec-safe-bin-trust.test.ts passed after the final rebase.

Fresh GitHub checks are queued on the prepared head; I did not merge while those are pending.

@clawsweeper re-review

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Updated prepared head to 290418af5a6516477df180c0526993fb412e87b5.

Follow-up from CI: after the final base rebase, exec-safe-bin-trust.test.ts had two stale os.tmpdir() references because current main now uses the shared withTempDir helper. I changed the new tests to use withTempDir and force-pushed the prepared branch.

Real behavior proof now passes on the PR body. Fresh CI is running; I am not merging while checks are pending/failing.