fix(tui): clarify Ctrl+C status when run is still active#38502
fix(tui): clarify Ctrl+C status when run is still active#38502mwfj wants to merge 28 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR makes a targeted UX-only fix to Key implementation details:
Safe to merge. Confidence Score: 5/5
Last reviewed commit: 6e23473 |
|
Update on the recurring secrets CI failure:
Tracking + fix are now split out as requested:
Expect the wait the secrets CI failure fixed by upstream |
|
Code is ready to review |
|
CI follow-up after conflict resolution:
Given this, the issue is not introduced by this PR, and we are Ready to review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f846eb8bcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex review: needs changes before merge. Summary Reproducibility: yes. Source inspection shows Next step before merge Security Review findings
Review detailsBest possible solution: Repair this text-only PR so the hint covers both pending optimistic sends and bound active runs, or choose #44223 if maintainers want Ctrl+C to abort active runs instead. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows Is this the best way to solve the issue? No as written. A status-only clarification is a narrow maintainable fix under the current documented policy, but the predicate must include pending optimistic submissions and the PR needs changelog coverage. Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against bc0b54e84485. |
|
Close PR due to this fix: #77199 |
Summary
/abortstops runs)Problem
Users can press Enter then Ctrl+C quickly and see local status text that reads like cancellation, while the run still completes and emits a reply.
This is a UX mismatch, not a backend run-cancel bug.
Root cause
Ctrl+Cis wired toresolveCtrlCAction(clear/warn/exit) insrc/tui/tui.ts; it does not callchat.abort.Fix
When
activeChatRunIdexists, append this hint to Ctrl+C status:; run still active (Esc or /abort to stop)So users immediately know the run is still in progress and how to stop it.
Scope
src/tui/tui.tsSecurity impact
Linked