fix(extensions): synthesize mediaLocalRoots propagation across sendMedia adapters by Takhoffman · Pull Request #33799 · openclaw/openclaw

Takhoffman · 2026-03-04T02:39:45Z

Summary

This PR synthesizes overlapping fixes to restore deterministic mediaLocalRoots propagation through extension sendMedia adapters, so local media paths resolve from configured roots instead of silently dropping roots at extension boundaries.

Synthesis Scope

fix(googlechat extension): honor mediaLocalRoots in sendMedia #33581 (googlechat)
fix(slack extension): forward mediaLocalRoots in sendMedia #33545 (slack)
fix(imessage extension): forward mediaLocalRoots in sendMedia #33540 (imessage)
fix(signal extension): forward mediaLocalRoots in sendMedia #33536 (signal)
fix(whatsapp extension): forward mediaLocalRoots in sendMedia #33528 (whatsapp)

What changed

Google Chat: sendMedia now uses local-capable media loading and passes roots to localRoots.
Slack: forwards mediaLocalRoots through outbound sendMedia.
iMessage: forwards mediaLocalRoots through helper + outbound sendMedia path.
Signal: forwards mediaLocalRoots through helper + outbound sendMedia path.
WhatsApp: forwards mediaLocalRoots through outbound sendMedia.
Added local-path fixture coverage for each affected extension send path.
Added a single changelog fix entry with synthesis attribution.

Invariant

For local media paths, roots are propagated unchanged to the downstream loader/sender.
For non-local media URLs, existing behavior remains unchanged.

Verification

pnpm install --frozen-lockfile
pnpm build
pnpm check
pnpm test:macmini
pnpm test extensions/googlechat/src/channel.outbound.test.ts extensions/slack/src/channel.test.ts extensions/imessage/src/channel.outbound.test.ts extensions/signal/src/channel.test.ts extensions/whatsapp/src/channel.test.ts

Notes

This synthesis supersedes the extension-level root propagation deltas from #33581, #33545, #33540, #33536, and #33528.

greptile-apps · 2026-03-04T02:43:51Z

Greptile Summary

This PR synthesizes mediaLocalRoots propagation fixes across five extension sendMedia adapters (Google Chat, Slack, iMessage, Signal, WhatsApp), ensuring local media paths resolve from configured roots instead of silently dropping them at extension boundaries. The implementation is correct and well-tested, with each affected adapter receiving a focused new test case.

Key changes:

Google Chat: Replaces runtime.channel.media.fetchRemoteMedia with runtime.media.loadWebMedia, passing localRoots when mediaLocalRoots is provided. The WebMediaOptions type confirms localRoots is a supported field, making the API usage valid.
Slack & WhatsApp: Destructure mediaLocalRoots and pass it directly (possibly undefined) to the downstream send function — slightly inconsistent with the conditional-spread pattern used in Signal and iMessage, but functionally correct since downstream functions handle absent/undefined roots gracefully.
iMessage & Signal: Use a conditional spread (...(params.mediaLocalRoots?.length ? { mediaLocalRoots: params.mediaLocalRoots } : {})) through the internal outbound helper, which is the safer pattern.
The Google Chat channel.outbound.test.ts only covers the new local-path case; there is no test covering the remote URL path, which changed from fetchRemoteMedia to loadWebMedia and was previously untested.

Confidence Score: 4/5

PR is safe to merge; changes are narrowly scoped to forwarding an existing field through adapter call chains with correct type usage throughout.
The implementation is correct: WebMediaOptions.localRoots is a valid field, the Google Chat API switch from fetchRemoteMedia to loadWebMedia is type-safe, and the new tests confirm the propagation invariant for each adapter. Score is 4 rather than 5 because the Google Chat outbound test only exercises the local-path branch, leaving the remote-URL behavioral change (fetchRemoteMedia → loadWebMedia) without any test coverage in the test suite.
extensions/googlechat/src/channel.outbound.test.ts — missing a remote-URL test case to cover the change from fetchRemoteMedia to loadWebMedia.

_{Last reviewed commit: 621ed20}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 621ed20b9a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Takhoffman · 2026-03-04T02:52:42Z

Addressed the review findings in commit 725dc05:

Google Chat sendMedia now preserves the prior remote URL path (fetchRemoteMedia) with the configured maxBytes cap, while still using loadWebMedia + localRoots for local paths.
Added remote URL regression coverage in extensions/googlechat/src/channel.outbound.test.ts to verify:
- remote URLs use fetchRemoteMedia with capped bytes
- loadWebMedia is not used for remote URLs
- upload + send still complete successfully

Re-ran:

pnpm test extensions/googlechat/src/channel.outbound.test.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3921440f3a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-04T03:27:24Z

-        maxBytes: maxBytes ?? (account.config.mediaMaxMb ?? 20) * 1024 * 1024,
-      });
+      const effectiveMaxBytes = maxBytes ?? (account.config.mediaMaxMb ?? 20) * 1024 * 1024;
+      const loaded = /^https?:\/\//i.test(mediaUrl)


Trim mediaUrl before checking HTTP scheme

googlechatPlugin.outbound.sendMedia now branches on /^https?:\/\// using the raw mediaUrl, but the previous code path always sent the URL to fetchRemoteMedia, whose URL parsing tolerates surrounding whitespace. This means inputs like " https://example.com/image.png " are now misclassified as local paths and sent to loadWebMedia, which fails with local-path allowlist errors instead of downloading the remote media. Normalizing/trimming the URL before the scheme check preserves the prior remote behavior for whitespace-padded URLs.

Useful? React with 👍 / 👎.

greptile-apps Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread extensions/googlechat/src/channel.outbound.test.ts

chatgpt-codex-connector Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread extensions/googlechat/src/channel.ts Outdated

openclaw-barnacle Bot added the extensions: memory-core Extension: memory-core label Mar 4, 2026

chatgpt-codex-connector Bot reviewed Mar 4, 2026

View reviewed changes

bmendonca3 and others added 8 commits March 3, 2026 21:27

googlechat: honor mediaLocalRoots in extension sendMedia

d4c4ecd

googlechat extension: assert sendMedia stays on local media path

e843217

slack: forward mediaLocalRoots in extension sendMedia

3043d95

imessage: forward mediaLocalRoots in extension sendMedia

d0dd2fb

signal: forward mediaLocalRoots in extension sendMedia

72cdfa7

whatsapp: forward mediaLocalRoots in extension sendMedia

11be487

Changelog: add synthesis entry for extension media roots

9f31267

Googlechat: preserve remote fetch path and add coverage

9d1a46e

Takhoffman force-pushed the task/media-root-synthesis-ws3 branch from 3921440 to 9d1a46e Compare March 4, 2026 03:30

Takhoffman merged commit 87e6ce7 into main Mar 4, 2026
9 checks passed

openclaw-barnacle Bot removed the extensions: memory-core Extension: memory-core label Mar 4, 2026

Takhoffman deleted the task/media-root-synthesis-ws3 branch March 4, 2026 03:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(extensions): synthesize mediaLocalRoots propagation across sendMedia adapters#33799

fix(extensions): synthesize mediaLocalRoots propagation across sendMedia adapters#33799
Takhoffman merged 8 commits intomainfrom
task/media-root-synthesis-ws3

Takhoffman commented Mar 4, 2026

Uh oh!

greptile-apps Bot commented Mar 4, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Takhoffman commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Takhoffman commented Mar 4, 2026

Summary

Synthesis Scope

What changed

Invariant

Verification

Notes

Uh oh!

greptile-apps Bot commented Mar 4, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Takhoffman commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants