Skip to content

test: align commands.test.ts with acceptsArgs field in getPluginCommandSpecs#33362

Closed
lewiswigmore wants to merge 1 commit intoopenclaw:mainfrom
lewiswigmore:fix/plugin-commands-test-acceptsArgs
Closed

test: align commands.test.ts with acceptsArgs field in getPluginCommandSpecs#33362
lewiswigmore wants to merge 1 commit intoopenclaw:mainfrom
lewiswigmore:fix/plugin-commands-test-acceptsArgs

Conversation

@lewiswigmore
Copy link
Copy Markdown
Contributor

Summary

getPluginCommandSpecs() now returns an acceptsArgs boolean for each command spec, but the unit test assertion was not updated to include the new field, causing CI failures across all open PRs.

Changes

  • Added acceptsArgs: false to the expected output in the getPluginCommandSpecs() test assertion

Test

This fixes the failing src/plugins/commands.test.ts test on main.

getPluginCommandSpecs() now returns acceptsArgs for each command spec,
but the test was not updated to expect the new field, causing CI failures.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 3, 2026

Greptile Summary

This PR fixes a failing CI test by adding the missing acceptsArgs: false field to the getPluginCommandSpecs() assertion in src/plugins/commands.test.ts. The source implementation in commands.ts already returns acceptsArgs: cmd.acceptsArgs ?? false for each spec, but the test expectation was not updated to include this field, causing assertion mismatches.

The one-line test fix is correct: the test command is registered without an explicit acceptsArgs value, so the implementation resolves it to false via the nullish coalescing operator, and the updated assertion now matches. No production code is modified; this is a pure test alignment fix with no risk of regressions.

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, correct test assertion fix with no production code changes.
  • This PR is a single-line test assertion update that directly mirrors the existing acceptsArgs ?? false default in the source implementation. There is no ambiguity in correctness and no risk of regression. The change is fully verified against the actual implementation.
  • No files require special attention.

Last reviewed commit: 9f4e469

@vincentkoc vincentkoc added the r: no-ci-pr Auto-close: PR only chasing known main CI/test failures. label Mar 20, 2026
@openclaw-barnacle
Copy link
Copy Markdown

Please don't make PRs for test failures on main.

The team is aware of those and will handle them directly on the codebase, not only fixing the tests but also investigating what the root cause is. Having to sift through test-fix-PRs (including some that have been out of date for weeks...) on top of that doesn't help. There are already way too many PRs for humans to manage; please don't make the flood worse.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r: no-ci-pr Auto-close: PR only chasing known main CI/test failures. size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants