fix(discord): ignore wildcard key in unresolved audit channels#32528
Closed
bmendonca3 wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(discord): ignore wildcard key in unresolved audit channels#32528bmendonca3 wants to merge 1 commit intoopenclaw:mainfrom
bmendonca3 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a false-positive Key changes:
Confidence Score: 5/5
Last reviewed commit: fdb121d |
18 tasks
Member
|
Superseded by #33125 (includes the Discord wildcard audit fix). Please use that PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openclaw doctor/channels status --probereportsunresolvedChannels=1for valid Discord guild channel wildcard config (channels.discord.guilds.<id>.channels."*").*wildcard key from unresolved-channel counting, and a regression test covers wildcard-only guild config.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
openclaw doctorandopenclaw channels status --probeno longer count Discord channel wildcard keys (*) as unresolved channel IDs.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation: N/ARepro + Verification
Environment
{ "channels": { "discord": { "guilds": { "1478116902202114240": { "channels": { "*": { "allow": true } } } } } } }Steps
channels.discord.guilds.<guildId>.channels."*").collectDiscordAuditChannelIds) via doctor/status flows.Expected
unresolvedChannels.Actual
*was treated as unresolved/non-numeric and incrementedunresolvedChannelsby 1.Evidence
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm vitest run src/discord/audit.test.tspasses, including new wildcard regression case.channelIds=[]andunresolvedChannels=0.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/discord/audit.ts,src/discord/audit.test.ts.Risks and Mitigations
*; all other non-numeric keys remain unresolved and existing test coverage is retained.