fix(synology-chat): resolve duplicate makeReq test conflict#32122
fix(synology-chat): resolve duplicate makeReq test conflict#32122markfietje wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR fixes two targeted regressions introduced by upstream API drift. Both changes are minimal, well-scoped, and do not introduce new logic.
Confidence Score: 5/5
Last reviewed commit: 2c49aeb |
c165c60 to
e0cd305
Compare
|
Merging this PR is a prerequisite for unblocking the CI status of other scoped fixes. Keeping these separate ensures each change maintains the smallest possible scope and is independently verifiable. |
|
|
|
|
d804296 to
4578f51
Compare
|
Closing as recent refactors in main have resolved the immediate CI block. Glad to see the combined stack is now healthy. |
Summary
This PR fixes a duplicate declaration conflict in the Synology Chat tests where a local
makeReqhelper conflicted with an identical helper exported fromtest-http-utils.js.Problem
After recent upstream changes,
extensions/synology-chat/src/webhook-handler.test.tsfails to compile because it definesmakeReqwhich is also imported (or intended to be shared) viatest-http-utils.js.Solution
test-http-utils.tsto support optional headers and URL inmakeReq.makeReqimplementation inwebhook-handler.test.ts.Verification
pnpm checkandpnpm tsgopass 100% green.extensions/synology-chat/src/webhook-handler.test.ts(14 passed).