fix(launchd): set restrictive umask in generated gateway plist#32022
Merged
steipete merged 1 commit intoopenclaw:mainfrom Mar 2, 2026
Merged
fix(launchd): set restrictive umask in generated gateway plist#32022steipete merged 1 commit intoopenclaw:mainfrom
steipete merged 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryAdds explicit
Confidence Score: 5/5
Last reviewed commit: 368573e |
368573e to
936569f
Compare
Contributor
|
Landed via temp rebase onto main.
Thanks @liuxiaopai-ai! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
Umask, so service restarts after updates could inherit system default022and create new gateway/state files as world-readable (644).Umaskvalue of decimal63(octal077) in the shared plist builder used by gateway LaunchAgent installation.Umaskand the expected value.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
077(Umask=63in launchd plist), so newly created files default to owner-only permissions.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
Expected
Umaskkey with value63.Actual
Umask=63and launchd tests pass.Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm exec vitest run src/daemon/launchd.test.tspnpm lintpnpm tsgoCompatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/daemon/launchd-plist.tssrc/daemon/launchd.test.tsRisks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.