Skip to content

fix(docs): apply oxfmt formatting to docs/help/faq.md#31924

Closed
scoootscooob wants to merge 1 commit intoopenclaw:mainfrom
scoootscooob:fix/tsgo-duplicate-import-and-stale-api
Closed

fix(docs): apply oxfmt formatting to docs/help/faq.md#31924
scoootscooob wants to merge 1 commit intoopenclaw:mainfrom
scoootscooob:fix/tsgo-duplicate-import-and-stale-api

Conversation

@scoootscooob
Copy link
Contributor

@scoootscooob scoootscooob commented Mar 2, 2026

Summary

  • Apply oxfmt formatting to docs/help/faq.md which currently fails the format:check CI step on main, blocking the check job for all open PRs

Test plan

  • pnpm check passes locally (format:check, tsgo, all lint rules)

🤖 Generated with Claude Code

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Fixes three TypeScript compilation errors introduced by the gateway HTTP handler refactor (commit 2fd8264ab):

  • Removes duplicate registerPluginHttpRoute import in extensions/googlechat/src/monitor.ts (TS2300)
  • Removes stale registerHttpHandler() property from test mock in extensions/phone-control/index.test.ts — this method was removed from OpenClawPluginApi interface as part of the breaking change that deprecated api.registerHttpHandler() in favor of api.registerHttpRoute()
  • Adds explicit return type Promise<ReturnType<typeof createResponse>> to sendRequest() in src/gateway/server-http.test-harness.ts to resolve non-portable inferred type error (TS2742)

All fixes are minimal, correct, and directly address the compilation failures blocking CI on all open PRs.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • All three changes are straightforward TypeScript compilation fixes with no behavioral changes. The fixes correctly align with the breaking changes from the gateway refactor commit, removing deprecated API references and fixing type inference issues. No logical errors, security concerns, or side effects.
  • No files require special attention

Last reviewed commit: 19e0cc3

@scoootscooob scoootscooob force-pushed the fix/tsgo-duplicate-import-and-stale-api branch from 19e0cc3 to 93910e0 Compare March 2, 2026 17:26
@scoootscooob scoootscooob changed the title fix(types): resolve tsgo compilation errors from gateway refactor fix(docs): apply oxfmt formatting to docs/help/faq.md Mar 2, 2026
@openclaw-barnacle openclaw-barnacle bot added docs Improvements or additions to documentation and removed channel: googlechat Channel integration: googlechat gateway Gateway runtime extensions: phone-control labels Mar 2, 2026
The faq.md file fails the format:check CI step on main, blocking the
check job for all open PRs. Run oxfmt to fix the formatting.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@scoootscooob scoootscooob force-pushed the fix/tsgo-duplicate-import-and-stale-api branch from 93910e0 to d6a9ae8 Compare March 2, 2026 17:36
@scoootscooob
Copy link
Contributor Author

Closing — the fix has already been applied upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants