fix(config): clean up backup files after successful write#31764
Open
Bartok9 wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(config): clean up backup files after successful write#31764Bartok9 wants to merge 1 commit intoopenclaw:mainfrom
Bartok9 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Config backup files (.bak, .bak.1, etc.) contain sensitive data including: - Gateway tokens - API keys (Anthropic, Notion, etc.) - Channel credentials Previously, these backup files persisted indefinitely after config writes, creating unnecessary credential exposure. They are only needed for crash recovery during the write operation itself. This change adds cleanupConfigBackups() which removes all backup files after a successful config write, reducing the credential footprint. Fixes openclaw#31699
Contributor
Greptile SummaryThis PR adds automatic cleanup of config backup files (
Confidence Score: 5/5
Last reviewed commit: c6ff6c0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config backup files (
.bak,.bak.1, etc.) contain sensitive data including:Previously, these backup files persisted indefinitely after config writes, creating unnecessary credential exposure. They are only needed for crash recovery during the write operation itself.
Changes
cleanupConfigBackups()function tobackup-rotation.tsSecurity Impact
This reduces the credential footprint by removing backup files that previously persisted indefinitely, containing duplicate copies of all secrets.
Fixes #31699