Discord: guard message:received hook session keys#31264
Closed
webdevtodayjason wants to merge 1 commit intoopenclaw:mainfrom
Closed
Discord: guard message:received hook session keys#31264webdevtodayjason wants to merge 1 commit intoopenclaw:mainfrom
webdevtodayjason wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a bug where
The changes are well-tested with focused regression tests for both fallback paths. The logic correctly handles edge cases (undefined, empty strings, whitespace) and maintains backward compatibility by keeping default behavior unchanged when no valid session key is available. Confidence Score: 5/5
Last reviewed commit: 0d76f9f |
0d76f9f to
b58e104
Compare
18 tasks
Contributor
Author
|
Superseded by #33038, which carries the same fix rebased on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
message:receivedinternal hooks rely onSessionKey; when inbound context ends up with an empty/missing session key, hook dispatch is skipped.SessionKey->CommandTargetSessionKey).Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
message:receivedhooks now still emit when inbound context has noSessionKeybut hasCommandTargetSessionKey.Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
Steps
SessionKeyis empty/missing.dispatchReplyFromConfig.Expected
message:receivedinternal hooks emit when a fallback session key exists.Actual
SessionKeyabsent.CommandTargetSessionKey.Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm exec vitest run src/auto-reply/reply/dispatch-from-config.test.ts src/discord/monitor/message-handler.process.test.tspnpm exec oxlint src/auto-reply/reply/dispatch-from-config.ts src/auto-reply/reply/dispatch-from-config.test.ts src/discord/monitor/message-handler.process.ts src/discord/monitor/message-handler.process.test.tsSessionKey+ presentCommandTargetSessionKey.Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoFailure Recovery (if this breaks)
0d76f9fbb.src/auto-reply/reply/dispatch-from-config.tssrc/discord/monitor/message-handler.process.tsmessage:receivedinternal hook events.Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.