fix(hooks): emit internal message:sent for dispatcher-only reply paths by ou524u · Pull Request #30668 · openclaw/openclaw

ou524u · 2026-03-01T13:21:40Z

Summary

This fixes missing message:sent internal hook events for reply paths that use channel-provided dispatchers (not the standard deliverOutboundPayloads flow).

In practice, Feishu uses a custom dispatcher deliver callback for streaming/card/direct sends, so deliverOutboundPayloads-level emitMessageSent is bypassed and internal hooks never see message:sent.

Root cause

message:sent internal hooks were emitted from delivery plumbing that is only exercised by deliverOutboundPayloads/deliverOutboundPayloadsCore.
Dispatcher-only paths (e.g. Feishu custom deliver callback) successfully send messages but skip that emission point.
Additionally, the hook handler registry (Map) was module-scoped, so when bundling splits code across multiple chunks, registerInternalHook and triggerInternalHook could reference different Map instances — register succeeds but trigger finds no handlers.

Changes

1. Emit `message:sent` at dispatch layer (`dispatch-from-config.ts`)

After successful completion (recordProcessed("completed")), emit an internal message:sent hook when:

sessionKey is present, and
at least one payload was delivered (counts.tool + counts.block + counts.final > 0).

2. Global singleton hook registry (`internal-hooks.ts`)

Use Symbol.for("openclaw.internal-hooks.handlers") on globalThis so that registerInternalHook and triggerInternalHook always share one Map, even across bundled chunks.

Why `dispatch-from-config.ts`

dispatchReplyFromConfig is the common orchestration point across both:

routed deliveries (routeReply), and
dispatcher-driven deliveries (dispatcher.sendFinalReply).

Emitting here ensures internal hooks observe completion in both paths.

Validation

Unit tests: 64 passed (internal-hooks + dispatch-from-config)
Live Feishu e2e: Consecutive messages all show:
- message:received → 👏 CLAP reaction added
- message:sent → ✅ OK reaction added
- 3/3 consecutive passes confirmed by end user

Emit message:sent only after delivery outcome is known

This new hook is emitted with success: true immediately after sendFinalReply/routing bookkeeping, but sendFinalReply only confirms enqueueing and returns before delivery runs (createReplyDispatcher enqueues at src/auto-reply/reply/reply-dispatcher.ts and executes deliver asynchronously). In any transport failure after enqueue, internal hooks will still receive a successful message:sent, which can trigger downstream automations/metrics as false positives.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-01T13:24:46Z

+          to: ctx.To ?? ctx.From ?? "",
+          content: "",
+          success: true,
+          channelId: channel,
+          accountId: ctx.AccountId,


Use routed target fields for message:sent context

When replies are routed to a different originating channel (routeReply uses originatingChannel/originatingTo), this hook still reports to and channelId from the inbound context (ctx.To/ctx.From and channel). That produces incorrect metadata for cross-channel sends, so any internal hook filtering by destination/channel can execute against the wrong conversation.

Useful? React with 👍 / 👎.

greptile-apps · 2026-03-01T13:28:14Z

Greptile Summary

This PR successfully fixes missing message:sent internal hook events for channels that use custom dispatcher callbacks (like Feishu) instead of the standard deliverOutboundPayloads flow.

Key changes:

Added message:sent hook emission at the dispatch layer (dispatch-from-config.ts) after successful completion when sessionKey is present and at least one payload was delivered
Converted hook registry from module-scoped Map to global singleton using Symbol.for() on globalThis, fixing cross-chunk bundling issues where registration and triggering could reference different Map instances
Added test coverage for global singleton registry behavior

Implementation notes:

Hook emission at dispatch level uses empty content field (reasonable since multiple payloads may have been sent)
Channels using deliverOutboundPayloads may emit message:sent twice (once from deliver.ts with content, once from dispatch-from-config.ts without) — hooks should be idempotent as noted in comments
Emission occurs after queuing payloads for delivery, not after confirmed delivery (consistent with existing behavior)

Confidence Score: 5/5

This PR is safe to merge with minimal risk
Well-tested changes with clear intent. The global singleton pattern correctly solves the bundling issue, and the dispatch-level hook emission ensures coverage for all reply paths. E2E validation confirms the fix works in production. The duplicate emission scenario is acknowledged and acceptable given the architecture.
No files require special attention

_{Last reviewed commit: deb5208}

…ndition - Use Symbol.for('openclaw.internal-hooks.handlers') on globalThis so register and trigger always share one Map even across bundled chunks. - Widen message:sent trigger from (queuedFinal || routedFinalCount > 0) to (deliveredCount > 0) covering tool/block/final counts. - Add singleton registry test.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: deb5208616

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-01T14:43:29Z

+    const deliveredCount = counts.tool + counts.block + counts.final;
+    if (sessionKey && deliveredCount > 0) {


Exclude unsent routed payloads from message:sent emission

The new deliveredCount > 0 gate can report a sent message even when nothing was actually delivered on routed paths: routeReply returns ok: true for payloads that normalize to empty and are skipped (src/auto-reply/reply/route-reply.ts:85-99), and those ok results are counted before this hook is fired. In that case, message:sent is emitted with success: true although no outbound message was sent, which can trigger false positives in internal automations/metrics for cross-channel routing.

Useful? React with 👍 / 👎.

openclaw-barnacle · 2026-04-06T04:26:23Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

openclaw-barnacle · 2026-04-10T04:23:29Z

Closing due to inactivity.
If you believe this PR should be revived, post in #pr-thunderdome-dangerzone on Discord to talk to a maintainer.
That channel is the escape hatch for high-quality PRs that get auto-closed.

fix(hooks): emit message:sent for dispatcher-based reply delivery

bfaf5dd

openclaw-barnacle Bot added the size: XS label Mar 1, 2026

ou524u marked this pull request as draft March 1, 2026 13:23

chatgpt-codex-connector Bot reviewed Mar 1, 2026

View reviewed changes

openclaw-barnacle Bot added size: S and removed size: XS labels Mar 1, 2026

ou524u marked this pull request as ready for review March 1, 2026 14:38

chatgpt-codex-connector Bot reviewed Mar 1, 2026

View reviewed changes

This was referenced Mar 1, 2026

hooks: unify internal + plugin hook registries to fix 5 systemic bugs #30784

Closed

hooks: unify registry, fix 5 systemic bugs across both hook systems #30860

Closed

rudiheydra mentioned this pull request Mar 8, 2026

[Bug] Telegram channel does not fire message:sent hook events #29019

Closed

openclaw-barnacle Bot added the stale Marked as stale due to inactivity label Apr 6, 2026

openclaw-barnacle Bot closed this Apr 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(hooks): emit internal message:sent for dispatcher-only reply paths#30668

fix(hooks): emit internal message:sent for dispatcher-only reply paths#30668
ou524u wants to merge 2 commits intoopenclaw:mainfrom
ou524u:fix/internal-hooks-singleton

ou524u commented Mar 1, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 1, 2026

Uh oh!

chatgpt-codex-connector Bot Mar 1, 2026

Uh oh!

greptile-apps Bot commented Mar 1, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 1, 2026

Uh oh!

openclaw-barnacle Bot commented Apr 6, 2026

Uh oh!

openclaw-barnacle Bot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		const deliveredCount = counts.tool + counts.block + counts.final;
		if (sessionKey && deliveredCount > 0) {

Uh oh!

Conversation

ou524u commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Changes

1. Emit message:sent at dispatch layer (dispatch-from-config.ts)

2. Global singleton hook registry (internal-hooks.ts)

Why dispatch-from-config.ts

Validation

Related

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

openclaw-barnacle Bot commented Apr 6, 2026

Uh oh!

openclaw-barnacle Bot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ou524u commented Mar 1, 2026 •

edited

Loading

1. Emit `message:sent` at dispatch layer (`dispatch-from-config.ts`)

2. Global singleton hook registry (`internal-hooks.ts`)

Why `dispatch-from-config.ts`

greptile-apps Bot commented Mar 1, 2026 •

edited

Loading