fix: skip synthetic toolResult for aborted/errored assistant messages#3054
Closed
dominicnunez wants to merge 1 commit intoopenclaw:mainfrom
Closed
Conversation
6 tasks
b69c267 to
747b849
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip inserting synthetic
toolResultentries for assistant messages withstopReason: "error"or"aborted"Problem
When an assistant message is aborted mid-tool-call (e.g., due to timeout, reboot, or interrupt), the transcript repair mechanism inserts a synthetic
toolResult. On subsequent API calls, the abortedtoolCallmay be filtered out while the synthetictoolResultremains, causing Anthropic's API to reject the request with:This makes the session permanently broken until manual intervention.
Solution
Modified
extractToolCallsFromAssistant()to return[]when the assistant message hasstopReason: "error"or"aborted". This prevents synthetictoolResultentries from being created for incomplete tool calls that won't be included in API requests anyway.Testing
Fixes #1826
AI-Assisted PR
This PR was AI-assisted using Claude. The fix checks
stopReasonat the start ofextractToolCallsFromAssistant()and returns early for incomplete turns, preventing synthetic toolResults from being created for tool calls that never executed.