UI: extract gateway reconnect magic numbers into named constants#30407
Open
DhineshPonnarasan wants to merge 1 commit intoopenclaw:mainfrom
Open
UI: extract gateway reconnect magic numbers into named constants#30407DhineshPonnarasan wants to merge 1 commit intoopenclaw:mainfrom
DhineshPonnarasan wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves readability/maintainability of the UI WebSocket reconnect flow by replacing inline “magic numbers” in GatewayBrowserClient with named constants in ui/src/ui/gateway.ts (per #30402).
Changes:
- Introduces documented module-level constants for reconnect backoff parameters and connect-queue delay.
- Updates reconnect scheduling and connect-handshake timing to reference the new constants (no behavioral intent).
Comment on lines
+69
to
+88
| export const INITIAL_BACKOFF_MS = 800; | ||
|
|
||
| /** | ||
| * Reconnect backoff: maximum delay (ms) between reconnect attempts. | ||
| * Prevents unbounded growth during prolonged disconnections. | ||
| */ | ||
| export const MAX_BACKOFF_MS = 15_000; | ||
|
|
||
| /** | ||
| * Reconnect backoff: exponential growth multiplier applied after each failed attempt. | ||
| * e.g. 800 → 1360 → 2312 → ... → capped at MAX_BACKOFF_MS. | ||
| */ | ||
| export const BACKOFF_MULTIPLIER = 1.7; | ||
|
|
||
| /** | ||
| * Delay (ms) between WebSocket open and sending the connect handshake. | ||
| * Provides a window for the server to send a challenge nonce before the | ||
| * client initiates authentication. | ||
| */ | ||
| export const CONNECT_QUEUE_DELAY_MS = 750; |
There was a problem hiding this comment.
These reconnect tuning values are exported, but they appear to be only used internally within this module right now. If they aren’t intended to be part of the module’s supported surface area, consider removing export to avoid growing a de-facto public API (and making future tuning changes harder). If the export is intentional (e.g., for tests/config), it may be worth adding a brief note indicating the intended external consumers.
Suggested change
| export const INITIAL_BACKOFF_MS = 800; | |
| /** | |
| * Reconnect backoff: maximum delay (ms) between reconnect attempts. | |
| * Prevents unbounded growth during prolonged disconnections. | |
| */ | |
| export const MAX_BACKOFF_MS = 15_000; | |
| /** | |
| * Reconnect backoff: exponential growth multiplier applied after each failed attempt. | |
| * e.g. 800 → 1360 → 2312 → ... → capped at MAX_BACKOFF_MS. | |
| */ | |
| export const BACKOFF_MULTIPLIER = 1.7; | |
| /** | |
| * Delay (ms) between WebSocket open and sending the connect handshake. | |
| * Provides a window for the server to send a challenge nonce before the | |
| * client initiates authentication. | |
| */ | |
| export const CONNECT_QUEUE_DELAY_MS = 750; | |
| const INITIAL_BACKOFF_MS = 800; | |
| /** | |
| * Reconnect backoff: maximum delay (ms) between reconnect attempts. | |
| * Prevents unbounded growth during prolonged disconnections. | |
| */ | |
| const MAX_BACKOFF_MS = 15_000; | |
| /** | |
| * Reconnect backoff: exponential growth multiplier applied after each failed attempt. | |
| * e.g. 800 → 1360 → 2312 → ... → capped at MAX_BACKOFF_MS. | |
| */ | |
| const BACKOFF_MULTIPLIER = 1.7; | |
| /** | |
| * Delay (ms) between WebSocket open and sending the connect handshake. | |
| * Provides a window for the server to send a challenge nonce before the | |
| * client initiates authentication. | |
| */ | |
| const CONNECT_QUEUE_DELAY_MS = 750; |
Contributor
Greptile SummaryExtracted 4 magic numbers from
Confidence Score: 5/5
Last reviewed commit: 704d702 |
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces raw magic numbers in
GatewayBrowserClientreconnect logic with named, JSDoc-documented constants.Fixes #30402
Changes
ui/src/ui/gateway.tsINITIAL_BACKOFF_MS = 800— initial delay before first reconnectMAX_BACKOFF_MS = 15_000— reconnect backoff ceilingBACKOFF_MULTIPLIER = 1.7— exponential growth factor per attemptCONNECT_QUEUE_DELAY_MS = 750— grace window for server challenge nonceNotes
pnpm check)