fix(deps): restore node-domexception for google auth [AI-assisted]#30026
Open
adamya-singh wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(deps): restore node-domexception for google auth [AI-assisted]#30026adamya-singh wants to merge 1 commit intoopenclaw:mainfrom
adamya-singh wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR correctly reverts a problematic dependency substitution from PR #28318 that broke Google auth for Vertex-backed embedded runs. The fix removes the
Confidence Score: 4/5
Last reviewed commit: 24b34b3 |
nikolasdehor
approved these changes
Feb 28, 2026
nikolasdehor
left a comment
There was a problem hiding this comment.
Good diagnosis. Runtime correctness takes priority over deprecation warnings. The regression test using spawnSync for import-path verification is solid. One note: the PR body has 'Closes #' with no issue number. LGTM.
|
you save my life dude. that's really pain~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix npm global install deprecation warnings (#28318)replacednode-domexceptionwith@nolyfill/ domexception, which broke the Google auth import path used by Vertex-backed embedded runs.Cannot convert undefined or null to object, making Telegram/OpenClaw appear broken even though transport was healthy.fetch-blobtonode-domexception@1.0.0, and added an import-path regression test.
restore the warning-free dependency cleanup in this PR.
AI Assistance
AI Session Notes (sanitized)
node-domexceptionwith@nolyfill/domexception,breaking the
google-auth-library -> gaxios -> node-fetch -> fetch-blobimport pathCannot convert undefined or null to objectbefore OAuth token exchangenode-domexceptionalias/overridefetch-blob -> node-domexception@1.0.0src/infra/google-auth-import-regression.test.tsgaxiosdata URL smoke passedgoogle-auth-librarysetup no longer crashedpnpm vitest run src/infra/google-auth-import-regression.test.ts src/agents/pi-embedded-runner/google.test.tsChange Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Vertex-backed embedded runs no longer fail during Google auth setup due to the broken dependency substitution.
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation:Repro + Verification
Environment
Steps
Cannot convert undefined or null to objectbefore OAuth token exchange.Expected
Actual
gaxios -> node-fetch -> fetch-blob -> node-domexceptionimport path crashes before token exchange.Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
gaxiosfetch dependencies load via adata:URL requestgoogle-auth-libraryno longer crashes during setuppnpm vitest run src/infra/google-auth-import-regression.test.ts src/agents/pi-embedded-runner/google.test.tsfetch-blobback tonode-domexception@1.0.0Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoFailure Recovery (if this breaks)
package.json,pnpm-lock.yamlCannot convert undefined or null to objectduring Google/Vertexauth setup
Risks and Mitigations
node-domexception@1.0.0, so the earlier warning-suppression goal is no longer met.up.