fix(line): classify LINE M4A voice payloads as audio#29785
Closed
Sid-Qin wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(line): classify LINE M4A voice payloads as audio#29785Sid-Qin wants to merge 1 commit intoopenclaw:mainfrom
Sid-Qin wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryFixed LINE media classification to properly detect M4A audio files by checking the ISO BMFF Key changes:
Confidence Score: 5/5
Last reviewed commit: 45120bf |
LINE voice messages use ISO BMFF ftyp containers and were misclassified as video/mp4, which skipped audio transcription. Detect major audio brands (e.g. M4A) so voice attachments are treated as audio/mp4 and saved as .m4a.
18 tasks
Contributor
|
Superseded by #32546, which consolidates this LINE workstream into the merged canonical fix set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
video/mp4, so audio transcription did not run.ftypmajor brand and classifies known audio brands (for exampleM4A) asaudio/mp4; regression test added.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation: N/ARepro + Verification
Environment
channels.line.*enabled, inbound voice message payloadSteps
ftypM4A).Expected
audio/mp4) and treated as transcript-eligible media.Actual
video/mp4, bypassing audio transcription selection.Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm test -- --run src/line/download.test.ts(includes new M4A regression case).ftypstill maps tovideo/mp4; existing image detections unaffected.Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoFailure Recovery (if this breaks)
src/line/download.ts,src/line/download.test.ts.Risks and Mitigations
video/mp4.