Media: recurse TTL cleanup in nested subdirs by jink-ucla · Pull Request #29211 · openclaw/openclaw

jink-ucla · 2026-02-27T23:30:44Z

Summary

Problem: cleanOldMedia() only deleted expired files in the media root and first-level subdirectories.
Why it matters: stale files in nested subdirectories could accumulate indefinitely and waste disk.
What changed: media cleanup now recursively scans nested subdirectories and removes expired files at any depth.
What did NOT change: cleanup still only removes expired files (not directories), and media save semantics are unchanged.

Change Type

Scope

User-visible / Behavior Changes

Expired media files are now cleaned even when stored in nested media subdirectories.

Files Changed

src/media/store.ts
src/media/store.test.ts

Verification

Added regression test for nested subdirectory cleanup in src/media/store.test.ts.
pnpm check format stage passes; type-check currently fails on unrelated baseline error in src/agents/pi-embedded-runner-extraparams.test.ts
(TS2352).
Full test/build execution in this environment is partially blocked by subprocess permission limits (spawn EPERM).

Risks and Mitigations

Risk: recursive traversal could affect behavior in unusual directory structures.
Mitigation: logic still gates deletion strictly on mtime > ttl and only removes files; directories are preserved.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f142a207b3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

greptile-apps · 2026-02-27T23:34:57Z

Greptile Summary

Implemented recursive TTL cleanup for media files in nested subdirectories, fixing a bug where files beyond the first level weren't removed. The solution properly handles arbitrary nesting depth while preserving directory structure.

Recursively removes expired files at all directory depths (previously only first-level subdirectories)
Added test coverage for nested subdirectory cleanup
Clean refactoring with improved variable naming (full → fullPath, entries → mediaEntries)

Confidence Score: 4/5

This PR is safe to merge with minimal risk
Well-implemented fix with appropriate test coverage. The recursive logic correctly handles nested directories and preserves the existing cleanup behavior. A minor suggestion about symlink handling is noted in comments but represents an edge case in the application-managed media directory.
No files require special attention

_{Last reviewed commit: 03e37ee}

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6315604710

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75c287c9f3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jink-ucla · 2026-02-28T00:15:33Z

@codex reivew

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cbf73c27f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T00:17:57Z

      if (stat.isDirectory()) {
-        await removeExpiredFilesInDir(full);
+        await removeExpiredFilesRecursively(fullPath);


Skip symlinked top-level dirs before recursive cleanup

Using fs.stat on top-level media entries means symlinked directories are treated as real directories, and this new recursive call now walks the entire symlink target tree. In a setup like .openclaw/media/inbound -> /some/other/path, cleanOldMedia() can delete expired files outside the media store at arbitrary depth, which is a broader data-loss risk introduced by this recursion change; top-level entries should be lstated and symlink directories skipped.

Useful? React with 👍 / 👎.

jink-ucla · 2026-02-28T00:29:10Z

Ready to merge. @vincentkoc could you merge this when you have a moment?

jink-ucla · 2026-02-28T16:50:54Z

Ready to merge. @Takhoffman @Lukavyi could any of you merge this when you have a moment?

Lukavyi · 2026-02-28T19:34:33Z

I'm not a maintainer....yet 😅

jink-ucla · 2026-03-01T04:22:42Z

@vincentkoc @Takhoffman Bumping this as it's fully verified, all checks are passing, and it's marked as low-risk/XS. Would appreciate the merge when you have a second so I can clear these from my queue.

vincentkoc · 2026-03-06T19:38:44Z

Folding this into #38292 so the media retention fix lands as one reviewable path.

That branch keeps the recursive cleanup coverage from here and combines it with the media.ttlHours config and gateway-owned startup/hourly cleanup needed to fully address #33078.

Keeping this linked for contributor credit because the nested-subdirectory cleanup work came from this PR.

vincentkoc · 2026-03-07T03:08:28Z

Resolved in #38292

Media: recurse TTL cleanup in nested subdirs

f142a20

openclaw-barnacle Bot added the size: XS label Feb 27, 2026

chatgpt-codex-connector Bot reviewed Feb 27, 2026

View reviewed changes

Comment thread src/media/store.ts Outdated

jink-ucla added 2 commits February 27, 2026 15:33

Merge branch 'main' into fix/media-cleanup-recursive-subdirs

e47e256

Merge branch 'main' into fix/media-cleanup-recursive-subdirs

03e37ee

greptile-apps Bot reviewed Feb 27, 2026

View reviewed changes

Comment thread src/media/store.ts Outdated

Update src/media/store.ts

6315604

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chatgpt-codex-connector Bot reviewed Feb 27, 2026

View reviewed changes

Comment thread src/media/store.ts

Merge branch 'main' into fix/media-cleanup-recursive-subdirs

75c287c

chatgpt-codex-connector Bot reviewed Feb 27, 2026

View reviewed changes

Comment thread src/media/store.ts

Media: recurse into nested dirs during TTL cleanup

9cbf73c

chatgpt-codex-connector Bot reviewed Feb 28, 2026

View reviewed changes

vincentkoc self-assigned this Mar 6, 2026

vincentkoc mentioned this pull request Mar 6, 2026

fix(media): retain inbound media with recursive cleanup TTL #38292

Merged

vincentkoc mentioned this pull request Mar 6, 2026

fix(media): add periodic cleanup for all media files #24519

Closed

2 tasks

vincentkoc closed this Mar 7, 2026

Uh oh!

Conversation

jink-ucla commented Feb 27, 2026

Summary

Change Type

Scope

User-visible / Behavior Changes

Files Changed

Verification

Risks and Mitigations

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

greptile-apps Bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jink-ucla commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

jink-ucla commented Feb 28, 2026

Uh oh!

jink-ucla commented Feb 28, 2026

Uh oh!

Lukavyi commented Feb 28, 2026

Uh oh!

jink-ucla commented Mar 1, 2026

Uh oh!

vincentkoc commented Mar 6, 2026

Uh oh!

vincentkoc commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants