fix: increase VERIFY_TIMEOUT_MS from 10s to 120s for local LLMs#29102
Closed
NaturalTensor wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix: increase VERIFY_TIMEOUT_MS from 10s to 120s for local LLMs#29102NaturalTensor wants to merge 1 commit intoopenclaw:mainfrom
NaturalTensor wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Local LLMs (e.g. Qwen3 14B on laptop GPU via llama.cpp) can easily exceed 10s for the verification response. Bump to 120s so onboarding does not fail for users with slower local models. Closes openclaw#28972
Contributor
Greptile SummaryIncreased verification timeout from 10s to 120s to accommodate slower local LLMs during custom model onboarding.
Confidence Score: 3/5
Last reviewed commit: dc26bd9 |
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/commands/onboard-custom.test.ts
Line: 223
Comment:
Test advances timer by 10s but timeout is now 120s
```suggestion
await vi.advanceTimersByTimeAsync(120_000);
```
How can I resolve this? If you propose a fix, please make it concise. |
Member
|
Thank you for the contribution and for pushing this forward. We consolidated this fix path in #27380 so we can land one complete solution for onboarding custom-provider verification reliability with full test coverage. Closing this as superseded, with appreciation. |
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases the verification timeout during custom model onboarding from 10 seconds to 120 seconds.
Problem
Users running local LLMs (e.g., Qwen3 14B on a laptop GPU via llama.cpp) frequently exceed the 10-second verification timeout, causing onboarding to fail unnecessarily. The model works fine — it just needs more time to generate its first response.
Fix
Bump
VERIFY_TIMEOUT_MSfrom10_000(10s) to120_000(120s). This is generous enough for slow local models while still providing a reasonable upper bound.Closes #28972