fix(gateway): honor browser profile from request body for node proxy calls by Sid-Qin · Pull Request #28852 · openclaw/openclaw

Sid-Qin · 2026-02-27T15:17:56Z

Summary

Problem: Browser proxy requests in gateway only read profile from query params, so calls that pass profile in POST body silently lose it.
Why it matters: Explicit profile: "openclaw" can be ignored and fall back to default profile (chrome), causing wrong runtime mode and startup errors.
What changed: Added resolveRequestedProfile() in src/gateway/server-methods/browser.ts to resolve profile from query.profile first, then fallback to body.profile.
What did NOT change: Browser routing, node command policy, profile selection logic outside request parsing.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes [Bug]: Browser profile selection bug: chrome profile overrides openclaw even when explicitly specified #28687

User-visible / Behavior Changes

Browser requests that pass profile in POST body now correctly honor that profile.
profile passed in query remains the highest-priority source.

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No
Command/tool execution surface changed? No
Data access scope changed? No

Repro + Verification

Environment

OS: Linux/macOS (gateway side)
Runtime: Node.js
Integration/channel: browser tool via gateway node proxy

Steps

Send a browser proxy request with POST body containing profile: "openclaw" and no query.profile.
Observe node proxy receives params.

Expected

Node proxy receives profile: "openclaw".

Actual

Before fix: profile was undefined unless put in query.
After fix: profile resolved from body when query does not provide it.

Evidence

Type-check passed after change:

pnpm -C /Users/sidqin/Desktop/openclaw-contrib exec tsc --noEmit --pretty false

Core change in src/gateway/server-methods/browser.ts:

old: profile: typeof query?.profile === "string" ? query.profile : undefined
new: profile: resolveRequestedProfile({ query, body })

Human Verification (required)

Verified scenarios: query profile provided; body profile provided; both missing.
Edge cases checked: whitespace-only profile values are trimmed and treated as empty.
What I did not verify: Full e2e browser session against live extension relay.

Compatibility / Migration

Backward compatible? Yes
Config/env changes? No
Migration needed? No

Failure Recovery (if this breaks)

How to disable/revert: Revert this commit.
Files/config to restore: src/gateway/server-methods/browser.ts
Known bad symptoms: profile may again be ignored when only present in POST body.

Risks and Mitigations

Low risk. Change is scoped to parsing profile input and keeps query precedence unchanged.

greptile-apps · 2026-02-27T15:20:33Z

Greptile Summary

Fixes gateway browser proxy to correctly read profile parameter from POST request body when query params don't provide it. Previously, profile in request body was silently ignored, causing fallback to default profile and potential startup errors. The new resolveRequestedProfile() function maintains query param precedence while enabling body fallback, following the same pattern already used in browser/routes/utils.ts. Implementation properly handles edge cases (empty/whitespace strings are treated as undefined). Tests verify both query precedence and body fallback behavior.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The fix is well-scoped, follows existing codebase patterns, includes appropriate tests, and solves a real bug without introducing breaking changes or security concerns
No files require special attention

_{Last reviewed commit: 98bf9a8}

nikolasdehor

The code change is correct — query-first precedence maintains backward compat, trim() prevents whitespace-only strings. Missing: tests and a proper PR description for review traceability.

…calls Gateway browser.request only read profile from query.profile before invoking browser.proxy on nodes. Calls that passed profile in POST body silently fell back to the default profile, which could switch users into chrome extension mode even when they explicitly requested openclaw profile. Use query profile first, then fall back to body.profile when present. Closes openclaw#28687

openclaw-barnacle · 2026-03-02T06:25:53Z