fix(signal): add stop callback to clear typing indicator on response complete#26932
Open
ClawdadBot wants to merge 2 commits intoopenclaw:mainfrom
Open
fix(signal): add stop callback to clear typing indicator on response complete#26932ClawdadBot wants to merge 2 commits intoopenclaw:mainfrom
ClawdadBot wants to merge 2 commits intoopenclaw:mainfrom
Conversation
|
This pull request has been automatically marked as stale due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The keepalive loop introduced in d42ef2a (v2026.2.24, #25886) continuously refreshes Signal's typing indicator every ~3s. Without a
stopcallback,fireStop()only halts the JS interval — no 'stop typing' API call is ever sent. Signal's indicator then persists until its own TTL expires, but that TTL kept getting reset by the keepalive, causing the perpetual typing indicator regression reported in #26891.Fix
Wire up the
stopcallback increateTypingCallbacksfor the Signal channel usingsendTypingSignalwith{ stop: true }. This explicitly clears the indicator when the response completes orNO_REPLYis returned.sendTypingSignalalready supported{ stop: true }— it just wasn't wired up for Signal.Notes
stopcallback (refs [Bug]: Telegram typing indicator persists indefinitely after response completes #26761, v2026.2.24 regression: Telegram typing indicator stays active after response completes #26841) — separate fix warranted thereNO_REPLYturnsCloses #26891
Greptile Summary
Added
stopcallback to Signal's typing indicator implementation to properly clear the typing indicator when responses complete orNO_REPLYis returned.stopcallback increateTypingCallbacksfor the Signal channelsendTypingSignalwith{ stop: true }to explicitly clear the indicatorstartcallback with proper guard clause for missingctxPayload.ToThe fix directly addresses the perpetual typing indicator regression where the keepalive loop continuously refreshed the indicator without ever sending a stop signal. The
sendTypingSignalfunction already supported thestopparameter - it just wasn't being used.Confidence Score: 5/5
Last reviewed commit: 4b0b120
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!