fix(discord): harden voice DAVE receive reliability by steipete · Pull Request #25909 · openclaw/openclaw

steipete · 2026-02-25T00:20:15Z

Summary

Restore @snazzah/davey runtime dependency for Discord VC DAVE support.
Reimplement and consolidate the strongest pending reliability fixes from related PRs:
- stale disconnect/destroyed event guards from fix(discord): keep active voice session on stale disconnect events #24339
- listener cleanup on stop from fix: remove speaking listener on voice disconnect #25312
Add first-class Discord voice DAVE config passthrough:
- channels.discord.voice.daveEncryption
- channels.discord.voice.decryptionFailureTolerance
Add controlled recovery for repeated decrypt failures (DecryptionFailed(...)) by triggering a rejoin attempt.
Add a dedicated regression suite for Discord voice manager lifecycle + DAVE behavior.

Why

Discord inbound STT is currently unreliable under DAVE receive failures (DecryptionFailed(UnencryptedWhenPassthroughDisabled)). This patch addresses the reliability regressions in OpenClaw's voice session lifecycle while exposing upstream DAVE knobs and improving recovery behavior.

Validation

pnpm lint
pnpm build
pnpm test
pnpm vitest run src/discord/voice/manager.test.ts

Dependency check (`@snazzah/davey`)

npm latest: 0.1.9 (published 2025-12-19)
npm downloads (last week): ~18k
repo activity: updated 2026-02-21

Mintlify

0 threads from 0 users in Mintlify

No unresolved comments

Greptile Summary

This PR hardens Discord voice DAVE receive reliability by restoring the @snazzah/davey runtime dependency, adding first-class DAVE config passthrough (daveEncryption, decryptionFailureTolerance), implementing stale connection event guards, cleaning up voice listeners on session teardown, and adding a controlled rejoin recovery mechanism for repeated decrypt failures.

Restores @snazzah/davey as a runtime dependency for @discordjs/voice DAVE encryption support
Adds channels.discord.voice.daveEncryption and channels.discord.voice.decryptionFailureTolerance config options with full schema, help text, labels, and documentation
Guards Disconnected/Destroyed event handlers against stale connections using a clearSessionIfCurrent identity check, preventing accidental removal of new sessions when old connection events fire
Properly removes all event listeners (speaking, disconnected, destroyed, player error) during stop(), preventing listener leaks across session lifecycle
Implements threshold-based decrypt failure recovery: after 3 DecryptionFailed(...) errors within a 30-second window, triggers a leave+rejoin cycle with a decryptRecoveryInFlight guard to prevent concurrent recovery attempts
Adds a dedicated regression test suite covering stale event guards, listener cleanup, DAVE option passthrough, and decrypt failure recovery

Confidence Score: 4/5

This PR is safe to merge — the changes are well-structured with proper edge case handling and regression tests.
The code changes are logically sound: stale event guards use connection identity checks, listener cleanup order is correct (remove listeners before destroy), the decrypt recovery mechanism has proper guard flags to prevent concurrent recovery, and the session lifecycle is well-managed. Config additions are complete across types, Zod schema, help text, labels, and docs. The new test suite covers the critical regression scenarios. Score is 4 rather than 5 because the decrypt recovery flow involves fire-and-forget async operations that could benefit from additional integration testing under real Discord conditions.
src/discord/voice/manager.ts — primary logic changes for DAVE recovery and session lifecycle hardening

_{Last reviewed commit: 9cd50c5}

Reimplements and consolidates related work: - #24339 stale disconnect/destroyed session guards - #25312 voice listener cleanup on stop - #23036 restore @snazzah/davey runtime dependency Adds Discord voice DAVE config passthrough, repeated decrypt failure rejoin recovery, regression tests, docs, and changelog updates. Co-authored-by: Frank Yang <frank.ekn@gmail.com> Co-authored-by: Do Cao Hieu <admin@docaohieu.com>

cursor · 2026-02-25T00:20:21Z

PR Summary

Medium Risk
Touches Discord voice connection lifecycle and introduces auto-rejoin logic, which could cause unexpected disconnect/reconnect behavior if thresholds or event handling are wrong, but changes are scoped and covered by new tests.

Overview
Improves Discord voice session stability under DAVE by restoring the @snazzah/davey dependency, adding configurable join passthrough (channels.discord.voice.daveEncryption and channels.discord.voice.decryptionFailureTolerance), and documenting the new options.

Hardens DiscordVoiceManager lifecycle by cleaning up listeners on stop and guarding against stale disconnect/destroy events from previous connections, plus adds controlled recovery that triggers a leave+rejoin after repeated DecryptionFailed(...) receive errors within a time window. A new vitest suite covers session replacement, listener teardown, DAVE option passthrough, and decrypt-failure rejoin behavior.

^{Written by Cursor Bugbot for commit 9cd50c5. This will update automatically on new commits. Configure here.}

steipete · 2026-02-25T00:20:38Z

Landed via fast-forward to main.

Included commit:

9cd50c51b04742f97f46ebd82ab13be6c944066a — fix(discord): harden voice DAVE receive reliability (Discord voice decrypt failure breaks inbound STT (UnencryptedWhenPassthroughDisabled) #25861)

What was landed:

Reimplemented stale-session guard behavior from fix(discord): keep active voice session on stale disconnect events #24339.
Reimplemented voice listener cleanup behavior from fix: remove speaking listener on voice disconnect #25312.
Restored @snazzah/davey runtime dependency (related to fix(discord): restore @snazzah/davey runtime dep for VC DAVE #23036).
Added Discord voice DAVE passthrough config (daveEncryption, decryptionFailureTolerance).
Added repeated decrypt-failure rejoin recovery for inbound voice receive.
Added regression tests in src/discord/voice/manager.test.ts.
Updated docs + changelog.

Validation run before landing:

pnpm lint
pnpm build
pnpm test

Thanks everyone who contributed the prior PRs/issues and repro detail.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cd50c51b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-25T00:25:28Z

src/discord/voice/manager.ts

+      logger.warn(`discord voice: decrypt recovery leave failed: ${leaveResult.message}`);
+      return;
+    }
+    const result = await this.join({ guildId: entry.guildId, channelId: entry.channelId });


Revalidate active target before recovery rejoin

After recoverFromDecryptFailures calls leave, it always issues join back to the old entry.channelId without checking whether another join request has started meanwhile. In the concurrent case (for example, an operator runs /vc join to a different channel while decrypt recovery is in flight), this stale recovery path can race and pull the bot back to the previous channel or leave multiple live connections competing for the same guild, causing unstable voice behavior.

Useful? React with 👍 / 👎.

openclaw-barnacle bot added docs Improvements or additions to documentation channel: discord Channel integration: discord gateway Gateway runtime size: M maintainer Maintainer-authored PR labels Feb 25, 2026

steipete merged commit 9cd50c5 into main Feb 25, 2026
12 checks passed

steipete deleted the fix/discord-voice-dave-reliability branch February 25, 2026 00:20

steipete temporarily deployed to github-pages February 25, 2026 00:21 — with GitHub Pages Inactive

steipete mentioned this pull request Feb 25, 2026

[Bug]: Discord voice joins but no speech output (DecryptionFailed: UnencryptedWhenPassthroughDisabled) #25372

Closed

mintlify bot deployed to staging - docs February 25, 2026 00:21 View deployment

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

jmdelpinob mentioned this pull request Feb 25, 2026

Discord voice connected but no live audio on 2026.2.24 (still reproduces after #25861/#25909) #26108

Open

mikejacksonS2F mentioned this pull request Feb 25, 2026

Discord voice decrypt failure breaks inbound STT (UnencryptedWhenPassthroughDisabled) #25861

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(discord): harden voice DAVE receive reliability#25909

fix(discord): harden voice DAVE receive reliability#25909
steipete merged 1 commit intomainfrom
fix/discord-voice-dave-reliability

steipete commented Feb 25, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

cursor bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

steipete commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

steipete commented Feb 25, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related

Validation

Dependency check (@snazzah/davey)

Mintlify

Greptile Summary

Confidence Score: 4/5

Uh oh!

cursor bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

steipete commented Feb 25, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

steipete commented Feb 25, 2026 •

edited by greptile-apps bot

Loading

Dependency check (`@snazzah/davey`)

cursor bot commented Feb 25, 2026 •

edited

Loading