UI/UX overhaul, enhanced theming, chat features, and config organization#25234
UI/UX overhaul, enhanced theming, chat features, and config organization#25234
Conversation
Additional Comments (1)
The original code filtered Prompt To Fix With AIThis is a comment left during a code review.
Path: ui/src/ui/app-render.ts
Line: 357-365
Comment:
**Update banner shows even when already up-to-date**
The original code filtered `updateAvailable` by checking `latestVersion !== currentVersion` before rendering the banner. That guard was removed in this refactor, so the banner will now render whenever `state.updateAvailable` is truthy, even if the user is already on the latest version.
```suggestion
state.updateAvailable && state.updateAvailable.latestVersion !== state.updateAvailable.currentVersion
? html`<div class="update-banner callout danger" role="alert">
<strong>Update available:</strong> v${state.updateAvailable.latestVersion}
(running v${state.updateAvailable.currentVersion}).
<button
class="btn btn--sm update-banner__btn"
?disabled=${state.updateRunning || !state.connected}
```
How can I resolve this? If you propose a fix, please make it concise. |
Summary of Changes
tysm @arosstale for your thorough feedback and focus on enhancements tied to UX. |
Done. Restored the version comparison guard so the update banner only renders when latestVersion !== currentVersion. |
|
@greptileai can you produce an updated review? |
b85b2f9 to
8b63e36
Compare
8b63e36 to
22dcd44
Compare
|
This branch has now been split into a stacked reviewable series to keep each PR comfortably below the file-count cap. Superseding stack:
Recommended review order: #36853 -> #36856 -> #36857. I’m leaving this PR open for now as the original umbrella/reference, but the stacked PRs are the intended review path. |
Overview
Complete redesign and enhancement of the Control UI dashboard with improved theming, chat capabilities, configuration organization, and user experience.
Theming & Design System
Chat Experience
Configuration & Settings
Authentication
Internationalization
Mobile & Responsive
Developer Experience
Stats
Testing
Notes
Greptile Summary
This PR delivers a comprehensive UI/UX modernization of the Control Dashboard with enhanced theming, chat capabilities, and improved configuration organization.
Major Changes:
claw,knot,dashwith light/dark modes), system theme support, and comprehensive CSS variable updates across 8+ style files/help,/status,/model,/think, etc.), collapsible tool messages, and improved grouped message renderingusageandcostfields in chat history (line 153-161 inchat.ts), improved error handling in config update controllerCode Quality:
data-codeattributes andlangclass (already flagged and fixed in previous thread)LEGACY_MAPlookupnavWidthvalidation range, unconditional history reload, and unescapedlangattributes have all been addressedArchitectural Notes:
components.css) and new style files (agent-chat.css,glass.css)chat.tsfor STT/slash menu is intentional for ephemeral UI stateConfidence Score: 4/5
navWidthvalidation, history reload performance, HTML escaping). The changes maintain backward compatibility, include extensive testing across themes/locales, and follow the repository's coding conventions. No breaking changes to core gateway functionality.ui/src/ui/storage.ts,ui/src/ui/app-gateway.ts, andui/src/ui/markdown.ts.Last reviewed commit: 2922a6e