fix(terminal): redirect note output to stderr in JSON/RPC mode#25152
Open
drvoss wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(terminal): redirect note output to stderr in JSON/RPC mode#25152drvoss wants to merge 1 commit intoopenclaw:mainfrom
drvoss wants to merge 1 commit intoopenclaw:mainfrom
Conversation
d5647b6 to
69335b9
Compare
c9aca76 to
d357bb4
Compare
3 tasks
|
This pull request has been automatically marked as stale due to inactivity. |
Contributor
Author
|
Updating this PR to keep it active. The fix is still valid and ready for review. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
53ec5ef to
975a747
Compare
Contributor
Author
|
Rebased onto current main with a clean single-commit branch. Guards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes src/terminal/note.ts write to stderr when loggingState.forceConsoleToStderr is set.
Also cherry-picks a pre-existing Windows CI test fix from PR #26049 ( est(bash-tools): fix Windows CI path prepend assertion). That fix is a prerequisite for the Windows test job to pass on any PR running the full Node test suite; it is unrelated to this feature change and was submitted as a standalone PR.
Change Type
Scope
Linked Issue
N/A
User-visible Changes
See summary above.
Security Impact (required)
No security impact. Logging output destination change only.
Repro + Verification
Evidence
Existing test suite passes on Linux and macOS.
Human Verification (required)
Compatibility
No breaking changes.
Failure Recovery
N/A
Risks
Low. Targeted single-file fix with existing test coverage.