Skip to content

test(exec): fix Windows-flaky sandbox implicit default test#24070

Closed
NathanFant wants to merge 1 commit intoopenclaw:mainfrom
NathanFant:fix/windows-exec-test-flakiness
Closed

test(exec): fix Windows-flaky sandbox implicit default test#24070
NathanFant wants to merge 1 commit intoopenclaw:mainfrom
NathanFant:fix/windows-exec-test-flakiness

Conversation

@NathanFant
Copy link

@NathanFant NathanFant commented Feb 23, 2026

Summary

  • The test "keeps sandbox as the implicit exec host default without forcing gateway approvals" (added in 45febec) uses yieldMs: 10 which causes intermittent failures on Windows CI because echo done doesn't always complete within 10ms.
  • Removed yieldMs: 10 so the exec command runs to completion, matching the pattern used in bash-tools.exec.path.test.ts.
  • No behavioral change — test still verifies sandbox default and gateway rejection.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

Security Impact (required)

  • New permissions/capabilities? No
  • Secrets/tokens handling changed? No
  • New/changed network calls? No
  • Command/tool execution surface changed? No
  • Data access scope changed? No

Human Verification (required)

Test-only change removing a timing-sensitive yieldMs: 10 that caused flakiness on Windows.

Compatibility / Migration

  • Backward compatible? Yes
  • Config/env changes? No
  • Migration needed? No

Risks and Mitigations

  • Risk: None.
    • Mitigation: N/A.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

Greptile Summary

Removed timing-sensitive yieldMs: 10 parameter from Windows-flaky test. The test "keeps sandbox as the implicit exec host default without forcing gateway approvals" (added in 45febec) was causing intermittent failures on Windows CI because echo done doesn't always complete within 10ms. Without yieldMs, the exec command runs to completion, matching the pattern in similar tests like bash-tools.exec.path.test.ts (line 87) and other tests in this file (lines 618, 625, 642).

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change removes only a timing parameter that was causing flakiness without affecting test logic. The test still verifies the sandbox default and gateway rejection behavior. The removal aligns with existing patterns in the codebase where simple commands like echo done run to completion without artificial time limits.
  • No files require special attention

Last reviewed commit: 143b80d

(5/5) You can turn off certain types of comments like style here!

@openclaw-barnacle openclaw-barnacle bot added agents Agent runtime and tooling size: XS labels Feb 23, 2026
@NathanFant
Copy link
Author

NathanFant commented Feb 23, 2026

Urgent review requested — this is a test-only fix that removes a Windows-flaky timing parameter (yieldMs: 10) causing intermittent CI failures on Windows. The failure is blocking all PRs from going green.

@steipete @Takhoffman — can one of you take a quick look and merge? Greptile already gave it 5/5 confidence. The change is a single-line removal with no behavioral impact.

@openclaw-barnacle
Copy link

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle bot added the stale Marked as stale due to inactivity label Mar 1, 2026
@Takhoffman Takhoffman added the close:superseded PR close reason label Mar 2, 2026
@Takhoffman
Copy link
Contributor

Closing as superseded.

The same implicit-sandbox exec flake scenario is already addressed on main in the current test shape (originating from 45febec plus subsequent test refactors).
No unique fix remains here.

@Takhoffman Takhoffman closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling close:superseded PR close reason size: XS stale Marked as stale due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants