test(exec): fix Windows-flaky sandbox implicit default test#24070
Closed
NathanFant wants to merge 1 commit intoopenclaw:mainfrom
Closed
test(exec): fix Windows-flaky sandbox implicit default test#24070NathanFant wants to merge 1 commit intoopenclaw:mainfrom
NathanFant wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Author
|
Urgent review requested — this is a test-only fix that removes a Windows-flaky timing parameter ( @steipete @Takhoffman — can one of you take a quick look and merge? Greptile already gave it 5/5 confidence. The change is a single-line removal with no behavioral impact. |
18 tasks
LalithaMV
approved these changes
Feb 23, 2026
|
This pull request has been automatically marked as stale due to inactivity. |
Contributor
|
Closing as superseded. The same implicit-sandbox exec flake scenario is already addressed on main in the current test shape (originating from 45febec plus subsequent test refactors). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yieldMs: 10which causes intermittent failures on Windows CI becauseecho donedoesn't always complete within 10ms.yieldMs: 10so the exec command runs to completion, matching the pattern used inbash-tools.exec.path.test.ts.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Security Impact (required)
Human Verification (required)
Test-only change removing a timing-sensitive
yieldMs: 10that caused flakiness on Windows.Compatibility / Migration
Risks and Mitigations
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Greptile Summary
Removed timing-sensitive
yieldMs: 10parameter from Windows-flaky test. The test "keeps sandbox as the implicit exec host default without forcing gateway approvals" (added in 45febec) was causing intermittent failures on Windows CI becauseecho donedoesn't always complete within 10ms. WithoutyieldMs, the exec command runs to completion, matching the pattern in similar tests likebash-tools.exec.path.test.ts(line 87) and other tests in this file (lines 618, 625, 642).Confidence Score: 5/5
echo donerun to completion without artificial time limits.Last reviewed commit: 143b80d
(5/5) You can turn off certain types of comments like style here!