Discord: handle early gateway startup errors#23832
Merged
steipete merged 1 commit intoopenclaw:mainfrom Feb 26, 2026
Merged
Conversation
8e380bd to
dea5d80
Compare
dea5d80 to
d1419bc
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorevents emitted during provider startup before lifecycle wait listeners are attached4014) as actionable/non-crashing while preserving fail-fast behavior for other fatal gateway errors4014, queued non-4014fatal errors, and pre-lifecycle emission captureRoot Cause
A Discord gateway
errorcould fire between client/plugin initialization andwaitForDiscordGatewayStoplistener registration. In that gap,Fatal Gateway error: 4014events were not owned by lifecycle handling and could surface as uncaught process exceptions.Testing
pnpm vitest run src/discord/monitor/provider.lifecycle.test.ts src/discord/monitor/provider.test.tspnpm exec oxlint --type-aware src/discord/monitor/provider.ts src/discord/monitor/provider.lifecycle.ts src/discord/monitor/provider.lifecycle.test.ts src/discord/monitor/provider.test.tspnpm exec oxfmt --check CHANGELOG.md src/discord/monitor/provider.ts src/discord/monitor/provider.lifecycle.ts src/discord/monitor/provider.lifecycle.test.ts src/discord/monitor/provider.test.tsGreptile Summary
Buffers Discord gateway
errorevents during provider startup to prevent uncaught exceptions when errors fire before lifecycle listeners attach. Disallowed intents (4014) are handled as actionable configuration guidance, while other fatal gateway errors preserve fail-fast behavior. Adds comprehensive test coverage for queued error scenarios and CHANGELOG entry.Confidence Score: 5/5
Last reviewed commit: 8e380bd
(2/5) Greptile learns from your feedback when you react with thumbs up/down!