fix(slack): enable thread reply reading in slack extension plugin#22216
Closed
lan17 wants to merge 4 commits intoopenclaw:mainfrom
Closed
fix(slack): enable thread reply reading in slack extension plugin#22216lan17 wants to merge 4 commits intoopenclaw:mainfrom
lan17 wants to merge 4 commits intoopenclaw:mainfrom
Conversation
The slack extension plugin's handleAction was missing includeReadThreadId: true when calling handleSlackMessageAction, causing message read with threadId to return channel-level messages instead of thread replies. The built-in adapter (channels/plugins/slack.actions.ts) already had this flag set, but the extension (extensions/slack/src/channel.ts) did not, and the extension overrides the built-in at runtime.
This was referenced Feb 20, 2026
This was referenced Feb 22, 2026
Member
|
Consolidating this into #23836 so we ship a single Slack extension threading fix with tests + changelog:
Closing this as superseded to keep review/merge clean. |
Member
|
Superseded by #23836. |
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message readwiththreadIdreturns channel-level messages instead of thread replies when the Slack extension plugin is activeincludeReadThreadId: trueto the extension'shandleSlackMessageActioncall inextensions/slack/src/channel.tsChange Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
message readwiththreadIdnow correctly returns thread replies (viaconversations.replies) instead of channel-level messages when the Slack extension plugin is active.Security Impact (required)
NoNoNo(already callsconversations.replieswhenthreadIdis present — this just enables the code path)NoNoRepro + Verification
Environment
Steps
messagetool withaction: "read",channelId: "C0ACPS2J7GV",threadId: "1771622303.670079",limit: 5Expected
Thread replies from the specified thread (via Slack
conversations.repliesAPI)Actual
Before fix: channel-level messages returned (
conversations.historycalled instead ofconversations.replies),threadIdsilently ignored.After fix: correct thread replies returned ✅
Evidence
Before fix (debug logging added to trace the issue):
Key line:
includeReadThreadId=false— the flag was not set by the extension, sothreadIdwas dropped before reachingreadSlackMessages.After fix:
conversations.repliescalled correctly, all 23 thread replies returned with correctthread_tsandparent_user_idfields.Human Verification (required)
readSlackMessages).Compatibility / Migration
YesNoNoFailure Recovery (if this breaks)
includeReadThreadId: trueline fromextensions/slack/src/channel.tsextensions/slack/src/channel.tsconversations.repliesRisks and Mitigations
None— this is a one-line flag addition that aligns the extension with the built-in adapter's existing behavior. Theconversations.repliescode path is already well-tested and used by the built-in adapter.Greptile Summary
Fixed a bug where reading Slack thread messages returned channel-level messages instead of thread replies. The extension's
handleActionwas missingincludeReadThreadId: true, which the built-in adapter already had. This flag controls whetherthreadIdis passed through to thereadMessagesaction.Confidence Score: 5/5
Last reviewed commit: 11a8f56
(4/5) You can add custom instructions or style guidelines for the agent here!