feat: unified status reactions for Discord and Telegram#20819
Closed
wolly-tundracube wants to merge 9 commits intoopenclaw:mainfrom
Closed
feat: unified status reactions for Discord and Telegram#20819wolly-tundracube wants to merge 9 commits intoopenclaw:mainfrom
wolly-tundracube wants to merge 9 commits intoopenclaw:mainfrom
Conversation
Author
|
@greptileai review |
src/channels/status-reactions.ts
Outdated
Comment on lines
+64
to
+66
| debounceMs: 700, | ||
| stallSoftMs: 25_000, | ||
| stallHardMs: 60_000, |
Contributor
There was a problem hiding this comment.
stall timing changed from Discord's original 10s/30s → 25s/60s - check this behavior change is intentional for existing Discord users
Suggested change
| debounceMs: 700, | |
| stallSoftMs: 25_000, | |
| stallHardMs: 60_000, | |
| stallSoftMs: 10_000, | |
| stallHardMs: 30_000, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/channels/status-reactions.ts
Line: 64-66
Comment:
stall timing changed from Discord's original 10s/30s → 25s/60s - check this behavior change is intentional for existing Discord users
```suggestion
stallSoftMs: 10_000,
stallHardMs: 30_000,
```
How can I resolve this? If you propose a fix, please make it concise.
Author
There was a problem hiding this comment.
Resolved — reverted defaults to 10s/30s for Discord compatibility. Telegram uses 25s/60s via messages.statusReactions.timing config override. See commit 30e3736.
Member
|
Superseded by #22190 (continued here because I don't have push permissions on the fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts Discord's inline status reaction system into a shared, channel-agnostic controller and adds Telegram support. Net result: -87 lines (removed 253, added 166).
What it does
Shows lifecycle emoji reactions on trigger messages as the agent progresses:
👀 (queued) → 🤔 (thinking) → 🔥/👨💻/⚡ (tool) → 👍 (done) or 😱 (error)
Features
exec,read,write), web (web_search,browser), and generic toolsConfig
{ "messages": { "statusReactions": { "enabled": true, "emojis": { "done": "🎉", "thinking": "🤔" }, "timing": { "stallSoftMs": 30000 } } } }Changes
New files
src/channels/status-reactions.ts— shared controller with adapter patternsrc/channels/status-reactions.test.ts— 34 unit testsDiscord (pure refactor, no behavior change)
src/discord/monitor/message-handler.process.ts— replaced 250-line inline implementation with shared controller + adapterTelegram (new feature)
src/telegram/bot-message-context.ts— controller creation with Telegram adaptersrc/telegram/bot-message-dispatch.ts— lifecycle hooks (setThinking, setTool, setDone, setError)Config schema
src/config/types.messages.ts—StatusReactionsConfigwith emoji + timing typessrc/config/zod-schema.session.ts— validation schemasrc/config/schema.labels.ts+schema.help.ts— labels and help textTesting
pnpm build✅ ·oxlint✅ ·vitest✅🤖 AI-Assisted Contribution
Greptile Summary
Extracts Discord's status reaction system into a shared controller (
src/channels/status-reactions.ts) and adds Telegram support. The refactor removes ~250 lines from Discord's message handler and replaces it with a configurable, channel-agnostic controller using an adapter pattern.Key changes:
messages.statusReactions.enabled)messages.statusReactionsconfig (emojis + timing)Potential concern:
Confidence Score: 4/5
src/channels/status-reactions.tsfor timing values if the stall duration change is not acceptableLast reviewed commit: 8457b1b
(2/5) Greptile learns from your feedback when you react with thumbs up/down!