fix(browser): skip port check when attachOnly is enabled#20611
Closed
unblockedgamesstudio wants to merge 3 commits intoopenclaw:mainfrom
Closed
fix(browser): skip port check when attachOnly is enabled#20611unblockedgamesstudio wants to merge 3 commits intoopenclaw:mainfrom
unblockedgamesstudio wants to merge 3 commits intoopenclaw:mainfrom
Conversation
When using attachOnly: true with localhost CDP URL (e.g., behind Nginx reverse proxy), OpenClaw was checking port availability and failing even though the user doesn't want to launch a local browser. This fix adds attachOnly to ResolvedBrowserProfile and skips the port availability check when attachOnly is true. Fixes openclaw#20595
|
This pull request has been automatically marked as stale due to inactivity. |
18 tasks
Member
|
Fixed by #31429 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using attachOnly: true with localhost CDP URL (e.g., behind Nginx reverse proxy), OpenClaw was checking port availability and failing even though the user doesn't want to launch a local browser.
This fix adds attachOnly to ResolvedBrowserProfile and skips the port availability check when attachOnly is true.
Fixes #20595
Testing
Note
This is an AI-assisted PR (built with OpenClaw). The fix is minimal (6 lines changed) and builds successfully. However, full testing requires setting up the Nginx + Cloudflare Tunnel environment described in the issue.