macOS: prevent Voice Wake crash when no input device is available#17948
Closed
agisilaos wants to merge 3 commits intoopenclaw:mainfrom
Closed
macOS: prevent Voice Wake crash when no input device is available#17948agisilaos wants to merge 3 commits intoopenclaw:mainfrom
agisilaos wants to merge 3 commits intoopenclaw:mainfrom
Conversation
c43c040 to
050b74e
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug
On Macs with no usable input device (common on Mac mini/headless setups), enabling Voice Wake can crash:
AVAudioNode.installTapOnBusthrows Objective-C exceptionSIGABRT)Root Cause
VoiceWakeRuntime.start(with:)proceeded toinstallTapwithout verifying that the default input device is both present and input-capable/alive.Changes
AudioInputDeviceObserverhasUsableDefaultInputDevice()inputAvailabilitySummary()for diagnosticsVoiceWakeRuntime.start(with:)AudioInputDeviceObserver.hasUsableDefaultInputDevice()before installing tapNSError(with input summary) and exits via existing catch/stop flowAudioInputDeviceObserverTestscovering:Validation
swift test --filter AudioInputDeviceObserverTestsswift test --filter VoiceWakeRuntimeTestsFixes