fix: Anthropic Prompt Caching Not Working - Missing cache_control Headers#17560
Closed
MisterGuy420 wants to merge 1 commit into
Closed
fix: Anthropic Prompt Caching Not Working - Missing cache_control Headers#17560MisterGuy420 wants to merge 1 commit into
MisterGuy420 wants to merge 1 commit into
Conversation
…acheRetention Fixes openclaw#17537
|
This pull request has been automatically marked as stale due to inactivity. |
Member
|
you have been detected be spamming with unwarranted prs and issues and your issues and prs have been automatically closed. please read contributing guide Contributing.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix resolves the issue where Anthropic prompt caching was not working even when
cacheRetentionwas configured. The problem was that the model config lookup did not handle model aliases (e.g., "sonnet" -> "anthropic/claude-sonnet-4-5") or short keys.Changes
resolveExtraParamsinextra-params.tsto:provider/modelIdparseModelRefTesting
Fixes #17537
Greptile Summary
Updated
resolveExtraParamsto handle model aliases and short keys when looking upcacheRetentionconfig. Previously only exactprovider/modelIdkeys were supported, preventing prompt caching from working when users configured models using aliases like "sonnet" or short keys. The fix adds a fallback chain: exact match → alias resolution viaparseModelRef→ short key match.Confidence Score: 5/5
parseModelRefhelper, includes debug logging for troubleshooting, and addresses a specific bug without introducing breaking changes or security concernsLast reviewed commit: 7432844