fix(slack): enable session-store lookup for announce target accountId#14912
Closed
mcaxtr wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(slack): enable session-store lookup for announce target accountId#14912mcaxtr wants to merge 1 commit intoopenclaw:mainfrom
mcaxtr wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Author
|
@greptile please re-review this PR. |
4874cbe to
4bdd0f6
Compare
d66e4eb to
dc739cf
Compare
bfc1ccb to
f92900f
Compare
268d1e6 to
12da9db
Compare
0e0f56d to
5df3b5f
Compare
5df3b5f to
d354f04
Compare
|
🤖 We're reviewing this PR with Aisle We're running a security check on the changes in this PR now. This usually takes a few minutes. ⌛ Progress:
Latest run failed. Keeping previous successful results. Trace ID: Last updated on: 2026-03-03T03:45:19Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessions_sendannounce replies use the default bot token instead of the target agent's token becauseresolveAnnounceTarget()returns the key-parsed fallback (noaccountId) for SlackpreferSessionLookupForAnnounceTarget: trueto Slack channel plugin meta, matching the existing WhatsApp patternresolveAnnounceTarget()logic or any other channel pluginChange Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
In multi-account Slack setups,
sessions_sendannounce replies now post using the correct bot token for the target agent's Slack account instead of always using the default account's token.Security Impact (required)
Repro + Verification
Environment
Steps
sessions_sendExpected
Actual
Evidence
New test in
src/agents/tools/sessions.test.tsverifiesresolveAnnounceTarget()hydratesaccountIdfromsessions.listfor Slack sessions. Test fails without the flag.Human Verification (required)
Compatibility / Migration
Failure Recovery (if this breaks)
preferSessionLookupForAnnounceTarget: truefromextensions/slack/src/channel.tsextensions/slack/src/channel.tsRisks and Mitigations
sessions.listcall to the announce path for Slack