Talk: handle redacted ElevenLabs API key on iOS/macOS#14645
Closed
oswalpalash wants to merge 3 commits into
Closed
Talk: handle redacted ElevenLabs API key on iOS/macOS#14645oswalpalash wants to merge 3 commits into
oswalpalash wants to merge 3 commits into
Conversation
3 tasks
Contributor
|
Merging into new alpha code path, thank you @oswalpalash. Ported into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Talk mode TTS fallback when gateway returns redacted config values.
iOS and macOS now handle redacted talk.apiKey correctly instead of silently dropping to system voice.
Greptile Overview
Greptile Summary
This PR improves Talk-mode TTS key resolution when the gateway redacts sensitive config values.
TalkModeManager.reloadConfig()to treat the__OPENCLAW_REDACTED__sentinel as “missing” and optionally use the local override.${...}placeholders) and resolves the final key via env → gateway → local config file, logging when a redacted value is detected.Overall this aligns mobile/desktop behavior so Talk mode doesn’t silently fall back to system voice when the gateway returns redacted
talk.apiKey.Confidence Score: 4/5
reloadConfig()only filters the redaction sentinel; if the gateway/config uses${...}placeholders, iOS will pass that through to ElevenLabs calls and fail consistently.