fix(config): migrate legacy top-level memorySearch#11656
Merged
Conversation
Member
Author
|
Addressed the Greptile migration-precedence concern in ee7332a:
Validation:
|
651e672 to
4f20216
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memorySearchtoagents.defaults.memorySearch.agents.defaults.memorySearchoverrides when both are present.Why
Fixes #11278 and #9143 by addressing a common config footgun where memory search settings are placed at top-level and silently fail modern schema expectations.
Changes
src/config/legacy.migrations.part-3.tsmemorySearch->agents.defaults.memorySearchmigration.src/config/legacy.rules.tsmemorySearch.src/config/config.legacy-config-detection.rejects-routing-allowfrom.test.tssrc/config/config.legacy-config-detection.accepts-imessage-dmpolicy.test.tsmemorySearch.docs/concepts/memory.mdagents.defaults.memorySearch).CHANGELOG.md#11278/#9143fix note.Validation
pnpm test src/config/config.legacy-config-detection.rejects-routing-allowfrom.test.ts src/config/config.legacy-config-detection.accepts-imessage-dmpolicy.test.tspnpm checkGreptile Overview
Greptile Summary
This PR adds a legacy-config migration to move top-level
memorySearchintoagents.defaults.memorySearch, plus a legacy detection rule so snapshot validation flags configs still using the old path. It also updates documentation and changelog, and adds regression tests covering both migration and snapshot legacy detection.The change integrates with the existing legacy migration pipeline (
LEGACY_CONFIG_MIGRATIONS_PART_3) and the legacy issue detection mechanism (LEGACY_CONFIG_RULES), ensuring users are warned/blocked on snapshot validation and auto-migrated on load.Confidence Score: 3/5
mergeMissing(existing, legacy)direction enforces a specific precedence and may not match the stated intent, which can lead to subtle config outcomes when both paths are present.