fix(memory/qmd): log when scope denies search#11652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory.qmd.scopedenies amemory_searchrequest.Why
Fixes #10191. Scope-denied searches were silently returning empty results, which looked like missing memory instead of policy gating.
Changes
src/memory/qmd-manager.tslogScopeDenied(sessionKey)helper.src/memory/qmd-manager.test.tslogs when qmd scope denies searchtest.docs/concepts/memory.mdCHANGELOG.md#10191fix note.Validation
pnpm test src/memory/qmd-manager.test.tspnpm checkGreptile Overview
Greptile Summary
This PR adds explicit warning logs when
memory.qmd.scopedenies amemory_searchrequest, including derivedchannel,chatType, and the session key in the log message to make scope-gated empty results easier to diagnose. It also adds a regression test that verifies the deny path returns[], emits the warning, and does not spawn the QMD query subprocess.The behavioral change is localized to
QmdMemoryManager.search()and uses the existing session-key parsing helpers (deriveChannelFromKey/deriveChatTypeFromKey) to populate the warning payload. Documentation and changelog are updated to reflect the new warning behavior.Confidence Score: 5/5