Summary

Fixes #5190

When the plugin-sdk is bundled separately from the main gateway code, each bundle gets its own listeners Set in diagnostic-events.ts. This causes events emitted by the gateway to never reach plugin subscribers using onDiagnosticEvent().

Root cause: The bundler inlines the diagnostic-events module into both dist/plugin-sdk/index.js and the main gateway bundles, creating separate module instances with independent state.

Fix: Use globalThis to share the listeners registry across all module instances, ensuring plugins receive diagnostic events properly.

Test plan

• Existing tests pass (pnpm test src/infra/diagnostic-events.test.ts)
• Verified plugins (diagnostics-otel, audit-neon) receive events after fix
• Verified audit records appear in database after fix

🤖 Generated with Claude Code

Greptile Summary

This PR fixes a bug where diagnostic event listeners in plugins (e.g., diagnostics-otel, audit-neon) never received events emitted by the gateway. The root cause was that the bundler inlined diagnostic-events.ts into both the plugin-sdk bundle and the main gateway bundle, creating separate module instances with independent listeners Sets and seq counters.

The fix replaces the module-scoped let seq and const listeners with a shared globalThis-backed state object keyed by "__openclaw_diagnostic_events__". A getGlobalState() helper lazily initializes the shared state on first access and returns the existing state on subsequent calls from any bundle.

• Single file change in src/infra/diagnostic-events.ts — moves seq and listeners into a DiagnosticGlobalState object stored on globalThis
• All existing functions (emitDiagnosticEvent, onDiagnosticEvent, resetDiagnosticEventsForTest) are updated to use the shared state reference
• The pattern is consistent with existing globalThis usage in the codebase (e.g., src/web/test-helpers.ts)

Confidence Score: 5/5

• This PR is safe to merge — it's a focused, minimal fix with no behavioral changes beyond sharing state across bundles as intended.
• The change is small and well-scoped (single file, ~30 lines). The globalThis pattern is a standard solution for cross-bundle state sharing in Node.js. The init guard correctly prevents overwriting existing state. All consumers (emit, subscribe, reset) operate through the same shared object reference. The approach is consistent with existing patterns in the codebase. No new APIs or behavioral changes are introduced beyond fixing the stated bug.
• No files require special attention.

_{Last reviewed commit: 4df7815}