fix(session-status): pass session-level overrides to buildStatusMessage (#10867)#10970
Closed
lailoo wants to merge 2 commits into
Closed
fix(session-status): pass session-level overrides to buildStatusMessage (#10867)#10970lailoo wants to merge 2 commits into
lailoo wants to merge 2 commits into
Conversation
bfc1ccb to
f92900f
Compare
Contributor
|
Closing as duplicate of #10998. If this is incorrect, please contact us. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10867 —
session_statustool was not passing session-level thinking/verbose/reasoning/elevated overrides tobuildStatusMessage, causing it to fall back to agent defaults (e.g. "Think: off") instead of the actual session value.Root Cause
The
/statuscommand path (commands-status.ts) correctly passesresolvedThink,resolvedVerbose,resolvedReasoning, andresolvedElevatedfrom the session entry tobuildStatusMessage. However, thesession_statustool (session-status-tool.ts) did not pass these parameters, sobuildStatusMessagefell back toagent.thinkingDefault ?? "off".Changes
src/agents/tools/session-status-tool.ts: PassresolvedThink,resolvedVerbose,resolvedReasoning,resolvedElevatedfromresolved.entrytobuildStatusMessage, matching the/statuscommand path.src/agents/openclaw-tools.session-status.test.ts: Add regression test verifyingthinkingLevel: "medium"displays asThink: medium(notThink: off).CHANGELOG.md: Add fix entry.Testing
Greptile Overview
Greptile Summary
session_statustool output by passing session-level thinking/verbose/reasoning/elevated overrides intobuildStatusMessage, matching the/statuscommand behavior.thinkingLevel: "medium"renders asThink: medium(and not the agent default).Confidence Score: 5/5
buildStatusMessage, matching the established/statuscode path, and include a focused regression test covering the previously incorrect behavior.