fix(cron): support NO_REPLY token for skipping delivery in isolated jobs#10809
Closed
AI-Chef wants to merge 2 commits intoopenclaw:mainfrom
Closed
fix(cron): support NO_REPLY token for skipping delivery in isolated jobs#10809AI-Chef wants to merge 2 commits intoopenclaw:mainfrom
AI-Chef wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Previously, cron isolated jobs only recognized HEARTBEAT_OK as a signal to skip message delivery. This caused issues when AI responded with NO_REPLY (the standard silent reply token used elsewhere in the codebase), resulting in 'request ended without sending any chunks' errors. This change adds support for NO_REPLY/SILENT_REPLY_TOKEN in the isHeartbeatOnlyResponse function, making cron jobs consistent with other parts of the system. Changes: - Import isSilentReplyText and SILENT_REPLY_TOKEN in helpers.ts - Check for NO_REPLY before checking HEARTBEAT_OK in isHeartbeatOnlyResponse - Add tests for NO_REPLY handling (skip delivery, deliver with media)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NO_REPLY(SILENT_REPLY_TOKEN) in cron isolated jobs to skip message deliveryHEARTBEAT_OKwas recognized, causing "request ended without sending any chunks" errors when AI responded withNO_REPLYProblem
Cron isolated jobs with
delivery.mode: "announce"would fail when the AI responded withNO_REPLYbecause:isHeartbeatOnlyResponsefunction only checked forHEARTBEAT_OKNO_REPLYis the standard silent reply token used elsewhere in the codebaseChanges
src/cron/isolated-agent/helpers.ts: Import and check forSILENT_REPLY_TOKENinisHeartbeatOnlyResponsesrc/cron/isolated-agent.delivers-response-has-heartbeat-ok-but-includes.test.ts: Add tests forNO_REPLYhandlingTesting
Related
This makes cron job behavior consistent with other parts of the system that already support
NO_REPLYviaisSilentReplyText().Greptile Overview
Greptile Summary
NO_REPLY(silent reply token) the same asHEARTBEAT_OKfor text-only responses.NO_REPLYskips delivery while still delivering when media is present.Confidence Score: 5/5
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
Context used:
dashboard- CLAUDE.md (source)dashboard- AGENTS.md (source)