feat(hooks): wire after_tool_call hook into tool execution pipeline by yassinebkr · Pull Request #10678 · openclaw/openclaw

yassinebkr · 2026-02-06T20:59:00Z

feat(plugins): add `after_tool_call` hook

Summary

Adds the after_tool_call plugin hook — the complement to before_tool_call (merged in #5513). Together they form the complete tool lifecycle pair for plugin observability.

What this PR does

New file: pi-tools.after-tool-call.ts — exports runAfterToolCallHook() and wrapToolWithAfterToolCallHook()
New file: pi-tools.after-tool-call.test.ts — 7 tests covering the full contract
Wired into pi-tools.ts — every tool now gets both before_tool_call and after_tool_call hooks applied

Design

Follows the exact same pattern as before_tool_call with key differences:

	`before_tool_call`	`after_tool_call`
Timing	Before tool execution	After tool execution (in `finally`)
Blocking	Yes — can block/modify params	No — fire-and-forget
Receives	`toolName`, `params`	`toolName`, `params`, `result`, `error`, `durationMs`
Hook errors	Logged, tool proceeds	Logged, never crash tool execution
Zero-overhead	`hasHooks` fast-path	`hasHooks` fast-path

Fire-and-forget semantics

The hook promise is deliberately not awaited — runAfterToolCallHook returns void (not Promise<void>). This ensures:

Tool results are returned immediately to the model
Slow hooks don't degrade agent responsiveness
Async hook errors are caught via .catch() on the promise

Error resilience

Three layers of protection:

hasHooks check — zero overhead when no plugins register after_tool_call
Synchronous try/catch around hookRunner.runAfterToolCall() call
.catch() on the returned promise for async failures

Tests

✓ executes tool normally when no hook is registered
✓ fires with correct event data after tool execution
✓ is fire-and-forget (does not block tool result)
✓ receives error info when tool execution fails
✓ continues execution when hook throws synchronously
✓ continues execution when hook rejects asynchronously
✓ normalizes non-object params for hook contract

References

Closes Feature: Wire up after_tool_call hook + exec auto-retry on failure #7297
Related: Plugin hooks (agent_end, before_tool_call, etc.) are never invoked #5513 (before_tool_call implementation)

Greptile Overview

Greptile Summary

This PR introduces an after_tool_call plugin hook and wires it into the tool wrapping pipeline so plugins can observe tool outcomes (result/error and duration) without blocking execution. It adds a new wrapper (wrapToolWithAfterToolCallHook) plus a vitest suite covering the hook contract, and updates createOpenClawCodingTools to apply both before/after tool-call hooks to every tool before abort-signal wrapping.

Confidence Score: 3/5

This PR is close to mergeable but has a hook semantics issue that can mislead plugins.
Core implementation and tests look consistent with existing hook runner patterns, but the current wrapper order will emit after_tool_call events even when before_tool_call blocks a tool call, which is likely not the intended meaning of “after tool call/execution” for observability hooks.
src/agents/pi-tools.ts (hook wrapping order/semantics), src/agents/pi-tools.after-tool-call.ts (event semantics)

Completes the before_tool_call/after_tool_call pair. before_tool_call was merged previously; this adds the after_tool_call counterpart. - after_tool_call fires after every tool execution (fire-and-forget) - Receives toolName, params, result/error, durationMs - Zero overhead when no hooks registered (hasHooks fast-path) - Hook errors caught and logged, never crash tool execution - 7 new tests, all passing Closes openclaw#5513 Ref openclaw#7297

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-06T21:00:42Z

src/agents/pi-tools.after-tool-call.ts

+import type { AnyAgentTool } from "./tools/common.js";
+import { createSubsystemLogger } from "../logging/subsystem.js";
+import { getGlobalHookRunner } from "../plugins/hook-runner-global.js";


Incorrect AnyAgentTool import

This file imports AnyAgentTool from ./tools/common.js, but the rest of the pi-tools.* wrappers use ./pi-tools.types.js (e.g. src/agents/pi-tools.abort.ts:1, src/agents/pi-tools.before-tool-call.ts:1). This introduces an inconsistent type source and can cause type divergence/TS build issues if those AnyAgentTool aliases ever change independently.

Suggested change

import type { AnyAgentTool } from "./tools/common.js";

import { createSubsystemLogger } from "../logging/subsystem.js";

import { getGlobalHookRunner } from "../plugins/hook-runner-global.js";

import type { AnyAgentTool } from "./pi-tools.types.js";

Prompt To Fix With AI

This is a comment left during a code review. Path: src/agents/pi-tools.after-tool-call.ts Line: 1:3 Comment: **Incorrect AnyAgentTool import** This file imports `AnyAgentTool` from `./tools/common.js`, but the rest of the `pi-tools.*` wrappers use `./pi-tools.types.js` (e.g. `src/agents/pi-tools.abort.ts:1`, `src/agents/pi-tools.before-tool-call.ts:1`). This introduces an inconsistent type source and can cause type divergence/TS build issues if those `AnyAgentTool` aliases ever change independently. ```suggestion import type { AnyAgentTool } from "./pi-tools.types.js"; ``` How can I resolve this? If you propose a fix, please make it concise.

Aligns with other pi-tools.* wrappers that import from pi-tools.types.js rather than tools/common.js. Both export the same type but pi-tools.types.js is the canonical source within the pi-tools namespace.

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-07T20:01:39Z

src/agents/pi-tools.ts

+  const withBeforeHooks = normalized.map((tool) => wrapToolWithBeforeToolCallHook(tool, hookCtx));
+  const withHooks = withBeforeHooks.map((tool) => wrapToolWithAfterToolCallHook(tool, hookCtx));
  const withAbort = options?.abortSignal


after_hook runs on blocks

after_tool_call is currently wrapped outside before_tool_call, so when a plugin blocks a call (before hook throws), the after_tool_call wrapper still runs its finally and emits an after_tool_call event with result: undefined and error: String(err) even though the underlying tool never executed. If after_tool_call is intended to represent “after actual tool execution”, you’ll want to avoid emitting it for before-hook blocks (e.g., by wrapping in the opposite order or by flagging/handling blocked outcomes distinctly).

Prompt To Fix With AI

This is a comment left during a code review. Path: src/agents/pi-tools.ts Line: 444:446 Comment: **after_hook runs on blocks** `after_tool_call` is currently wrapped *outside* `before_tool_call`, so when a plugin blocks a call (before hook throws), the `after_tool_call` wrapper still runs its `finally` and emits an `after_tool_call` event with `result: undefined` and `error: String(err)` even though the underlying tool never executed. If `after_tool_call` is intended to represent “after actual tool execution”, you’ll want to avoid emitting it for before-hook blocks (e.g., by wrapping in the opposite order or by flagging/handling blocked outcomes distinctly). How can I resolve this? If you propose a fix, please make it concise.

- Swap wrap order: after(inner) → before(outer), so after_tool_call only fires for calls that pass the before gate - Add string-match guard as defense-in-depth for blocked error messages - New test: verifies after_tool_call does not fire on blocked calls - Comment in pi-tools.ts explaining wrap order rationale

TheKnightCoder · 2026-02-10T06:44:23Z

would be great to get this merged in

openclaw-barnacle · 2026-02-21T04:30:35Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

openclaw-barnacle bot added the agents Agent runtime and tooling label Feb 6, 2026

greptile-apps bot reviewed Feb 6, 2026

View reviewed changes

fix: import AnyAgentTool from pi-tools.types.js for consistency

2aaf2fd

Aligns with other pi-tools.* wrappers that import from pi-tools.types.js rather than tools/common.js. Both export the same type but pi-tools.types.js is the canonical source within the pi-tools namespace.

yassinebkr closed this Feb 7, 2026

yassinebkr reopened this Feb 7, 2026

greptile-apps bot reviewed Feb 7, 2026

View reviewed changes

yassinebkr force-pushed the feat/after-tool-call branch from 96174d7 to dba545a Compare February 7, 2026 20:50

sebslight mentioned this pull request Feb 13, 2026

Wire up after_tool_call hook in agent execution loop #6264

Closed

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

sebslight mentioned this pull request Feb 19, 2026

fix: wire up after_tool_call plugin hook #13369

Closed

4 tasks

openclaw-barnacle bot added stale Marked as stale due to inactivity and removed stale Marked as stale due to inactivity labels Feb 21, 2026

vincentkoc self-assigned this Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(hooks): wire after_tool_call hook into tool execution pipeline#10678

feat(hooks): wire after_tool_call hook into tool execution pipeline#10678
yassinebkr wants to merge 3 commits intoopenclaw:mainfrom
yassinebkr:feat/after-tool-call

yassinebkr commented Feb 6, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 6, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 7, 2026

Uh oh!

TheKnightCoder commented Feb 10, 2026

Uh oh!

openclaw-barnacle bot commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

yassinebkr commented Feb 6, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feat(plugins): add after_tool_call hook

Summary

What this PR does

Design

Fire-and-forget semantics

Error resilience

Tests

References

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

TheKnightCoder commented Feb 10, 2026

Uh oh!

openclaw-barnacle bot commented Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yassinebkr commented Feb 6, 2026 •

edited by greptile-apps bot

Loading

feat(plugins): add `after_tool_call` hook