-
-
Notifications
You must be signed in to change notification settings - Fork 52.6k
Closed
Closed
Copy link
Labels
maintainerMaintainer-authored PRMaintainer-authored PR
Description
Summary
Workstream 1 landed canonical Windows fixes in:
- Process: fix Windows .cmd spawn EINVAL #29759
- fix(node-host): decode Windows exec output with active code page #30652
Remaining non-core spawn call sites still use mixed patterns and should be unified behind one tested Windows-safe strategy.
Scope
Unify Windows spawn behavior for these surfaces:
src/memory/qmd-manager.tsextensions/acpx/src/runtime-internals/process.tssrc/agents/sandbox/docker.tssrc/acp/client.ts
Requirements
- One coherent strategy for
.cmd/.bathandling. - No duplicate wrapper patterns (
shell:true+cmd /cdouble wrapping). - Explicit argument-safety guarantees where command-line synthesis is required.
- Keep blast radius minimal; avoid unrelated refactors.
Test Gates (required)
Add targeted tests per touched surface to prove:
- Windows
.cmdshims execute successfully. - No regression for non-Windows paths.
- No command mangling with quoted args/spaces.
- No new injection surface from shell/wrapper behavior.
Acceptance Criteria
- Shared strategy documented in code comments in the helper/call site.
- All new tests pass locally and in CI.
- No broad behavior changes outside Windows spawn behavior.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
maintainerMaintainer-authored PRMaintainer-authored PR