-
-
Notifications
You must be signed in to change notification settings - Fork 52.7k
Open
Description
Summary
The params field is defined in the TypeScript type (AgentEntry) but missing from the Zod validation schema (AgentEntrySchema). Since the schema uses .strict(), any params configuration is silently rejected at validation time, making the per-agent parameter overrides feature (introduced in PR #17470) unusable.
This was reported in #25903, which was closed after a maintainer checked main and concluded the issue was resolved. However, the schema mismatch still exists on main as of today.
Evidence (current main)
| File | params field |
|---|---|
src/config/types.agents.ts:33 |
Present — params?: Record<string, unknown> |
src/config/zod-schema.agent-runtime.ts (AgentEntrySchema, line 673-708) |
Missing |
src/config/zod-schema.agent-defaults.ts:27 (AgentDefaultsSchema) |
Present — params: z.record(z.string(), z.unknown()).optional() |
The defaults schema correctly includes params, but the per-agent entry schema does not.
Reproduction
- Add a
paramsfield to any agent entry in configuration - Validation fails because
AgentEntrySchema.strict()rejects undeclared keys
Fix
PR #26138 adds the missing field to AgentEntrySchema and includes regression tests. It is passing all CI checks (10,485 tests).
References
- Original issue: v2026.2.23 changelog lists features not present in published npm build (b817600) #25903 (closed — see my follow-up comment confirming the bug persists)
- Fix PR: fix(config): add missing params field to AgentEntrySchema #26138 (open, awaiting review)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels